1213628 - Port SeaMonkey's Compose in HTML/Compose in Text dropdown menu of Compose menubutton to Thunderbird

Status: VERIFIED WONTFIX

(Thunderbird :: Message Compose Window, enhancement)

Description

[WADA:World Anti-bad-Duping Agency]

This is spin-off of bug 1030288 comment #5.

SeaMonkey's HTML / Text dropdown menu of Compose menubutton is convenient.
Please port it to Thunderbird. 

In SeaMonkey, Compose menu button has next drop down menu.
   Compose in HTML
   Compose in Plain Text
In Thunderbird, Write menu button has next drop down menu.
   Message
   Event
   Task
Following may be convenient for Tb users.
  In Thunderbird, drop down menu of Write menubutton.
   Message (HTML)       , or opposite of current Identity setting is shown
   Message (Plain Text) , or current Identity setting is shown
   Event
   Task

I nelieve no need for Reply/Forward menubutton.

Comment 1

[:aceman]

Attachment: patch

This is a copy of the feature from Seamonkey. I added the word "message" into the items so that it is clear (what is written) when Lightning adds its items (Event and Task). If this passes, Lightning could probably remove the "Message" item as it would now be superfluous.

Comment 2

[:aceman]

(In reply to WADA from comment #0)
> I nelieve no need for Reply/Forward menubutton.

Interestingly, TB38 does have the submenu for format under Reply and "Reply all" toolbar buttons. I do not see it in trunk. Was that intentionally removed?

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 8672396 [details] [diff] [review]
patch

Looks good and makes sense for mouse users which don't know the shift modifier.

Comment 4

[Richard Marti (:Paenglab)]

(In reply to :aceman from comment #2)
> (In reply to WADA from comment #0)
> > I nelieve no need for Reply/Forward menubutton.
> 
> Interestingly, TB38 does have the submenu for format under Reply and "Reply
> all" toolbar buttons. I do not see it in trunk. Was that intentionally
> removed?

I don't see this with TB38 here.

Comment 5

[:aceman]

(In reply to Richard Marti (:Paenglab) from comment #4)
> > Interestingly, TB38 does have the submenu for format under Reply and "Reply
> > all" toolbar buttons. I do not see it in trunk. Was that intentionally
> > removed?
> 
> I don't see this with TB38 here.

Right, I also do not see it in Safe mode. Must be some good addon providing this.

Comment 6

[:aceman]

Paenglab, do you think I should also put the Write icon into the menuitems so that it looks nice when Lightning adds its items with icons? I mean to add the same icon that LT now uses for the Message menuitem.

Comment 7

[Richard Marti (:Paenglab)]

I think it's better not to use a icon for them. We would have both with the same icon which doesn't help for a better identification. With the removal of the Lightning's write menu there are only the two calendar entries and this helps differ from the two message menus.

Comment 8

[:aceman]

Comment on attachment 8672396 [details] [diff] [review]
patch

Review of attachment 8672396 [details] [diff] [review]:
-----------------------------------------------------------------

OK, thanks.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8672396 [details] [diff] [review]
patch

Review of attachment 8672396 [details] [diff] [review]:
-----------------------------------------------------------------

While I think this is a nice feature for people that know what HTML vs Text is, I am not sure this will be clear for everyone. I guess it may be since we also use "HTML" in other places, but alternatively, what about "Compose with plain text" and "Compose with rich formatting" ? Might be a little long though. I'll leave the decision on this up to the UX folks.

If you add those menu items, could you also patch Lightning to remove the message item? Codewise, I think you are missing type="menu-button" on the dropdown, this is added by Lightning.

Comment 10

[Richard Marti (:Paenglab)]

(In reply to Philipp Kewisch [:Fallen] from comment #9)
> Comment on attachment 8672396 [details] [diff] [review]
> patch
> 
> Review of attachment 8672396 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> While I think this is a nice feature for people that know what HTML vs Text
> is, I am not sure this will be clear for everyone. I guess it may be since
> we also use "HTML" in other places, but alternatively, what about "Compose
> with plain text" and "Compose with rich formatting" ? Might be a little long
> though. I'll leave the decision on this up to the UX folks.

Yes, this would be easier, but, in the prefs (Compose/General) and in Account Manager we are using "HTML".
If we change here to "Rich Text", then we should file a bug to change this too in prefs and AM.

Comment 11

[:aceman]

We are using "Rich text (HTML)" directly in the compose window (Options->delivery format) so using that in all places is not a bad idea. My only nit to this is that Outlook provides 3 options: Plain text, HTML and Rich text (RTF). So there may be space for some confusion. But if we use the full label everywhere as "Rich text (HTML)" (including the HTML), it should be clear.

Comment 12

[:aceman]

Attachment: patch v2

Thanks. This now includes the Calendar adaptation. It looks like it was also adding the "Message" item to Seamonkey. So this may help them too (as they already had the Write HTMl/Write plain items).

Comment 13

[Richard Marti (:Paenglab)]

Comment on attachment 8672757 [details] [diff] [review]
patch v2

ui-r+ with using a capital "T" in "text" for "Write Message in Rich text (HTML)".

Could the accesskey R instead of H for Rich?

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 8672757 [details] [diff] [review]
patch v2

Review of attachment 8672757 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, but I see no reason to add this. 
It creates a chore for the user for every click/misclick on the write button he does, and I don't think there's usually any need for people to decide. The current hidden feature of shift-clicking should be sufficient for the people who want it. Adding it to the write button would also be inconsistent if we didn't add it to all the other fwd/reply etc buttons, and we really don't want to go there...

Comment 15

[Magnus Melin [:mkmelin]]

(I believe there's also some wontfixed dupe of this, couldn't find it atm though.)

Comment 16

[WADA:World Anti-bad-Duping Agency]

(In reply to Magnus Melin from comment #14)
> The current hidden feature of shift-clicking should be sufficient for the people who want it.

Biggest problem for users in Shift modifier is "Hidden".
Please note that Thunderbird doesn't have embed Help Document, as Firefox doesn't have.
I believe that you already know "creation of almost text only mail using HTML mode" produces exess bug opens :-)  

> Adding it to the write button would also be inconsistent
> if we didn't add it to all the other fwd/reply etc buttons, and we really don't want to go there...

I agree with you on inconsistent,
I temporarily thought that HTML mode/Text mode is determined by display mode when Reply. I confused with Edit.

Addon is better? If addon, consistency is not needed.
Official Help document for "Shift modifier in mail composition" may be neede.
IIRC, there are some documents which states about Shift+Compose, but current consistent Shift modifier in mail composition is not explained.

> It creates a chore for the user for every click/misclick on the write button he does,

"Dropdown menu of Write button" is not new feature by this enhancement.
"Dropdown menu of Write button" surely already exists in Thunderbird.
This enhancement merely changes number of selectable dropdown menu from 3 to 4.
Non-chore when 3 sub menus but chore if 4 sub menus?

This reason is rejected by me.

Comment 17

[WADA:World Anti-bad-Duping Agency]

(In reply to Magnus Melin from comment #14)
> Adding it to the write button would also be inconsistent
> if we didn't add it to all the other fwd/reply etc buttons, and we really don't want to go there...

Consistency vs. Convenience.

Until a few years ago, Shift+Compose was provided only for Compose Button of Toolbar(Write in Tb).
Shift modifier was not supported in all other Toolbar buttons, all menus, all context menus.
(biggest reason was that who passed Shift was Compose button only)
So, Shift modifier was ported to all other Toolbar buttons, all menus, all context menus for "mail composition"(not Edit) a few years ago, by great efforts of developrs such as aceman.

If consistency in a program codes is most important in the world, far important than convenience for users, "Shift only in Compose/Write Toolbar button" must not have been implemented.
Please note:
As seen in "Shift only in Compose/Write Toolbar button" case, user's convenience is important than consistency in implementaton, consistency for developers, in some situations.

Comment 18

[WADA:World Anti-bad-Duping Agency]

Sorry typo. exess -> excess

Comment 19

[Magnus Melin [:mkmelin]]

Obviously yes, this is perfectly fine for an add-on to do.

Well the 3 items we have come from lightning, and I think the Write button is a fairly questionable place to have those - though at least they are clear so they don't make people think twice. HTML or not is just an implementation detail that normal people shouldn't have to think about.

Convenience for who? If it's not something people need/want in general, it's an inconvenience.

Comment 20

[WADA:World Anti-bad-Duping Agency]

(In reply to Magnus Melin from comment #19)
> Convenience for who? If it's not something people need/want in general, it's　an inconvenience.

You are correct.　Excessive function shoudn't be contained in standard package for majority of users.

> fine for an add-on to do.

Because XUL element can be created/removed/modified by JS code via DOM, and "Custom Buttons" addon is usable, "providing JS code only" is recently possible. if not so big/comlicated function.
We may be better to rovide such script only instead of enhancement of Thunderbird or addon package, if fuctions for limited users.

aceman, is WONTFIX acceptable? Or immediately re-open and fight with Magnus and call Gerv? :-) 
"Request of a button which user wants" is usually good candidate of it.

Comment 21

[:aceman]

I am OK with it. We have bigger problems to fix :) Also there already is some addon to do it, I already have those items also on Reply buttons in TB38.