1213696 - Can't edit livemarks

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[[e-mail]]

Because bug 1165316 missed two cases.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Philip Chee]

Comment on attachment 8672415 [details] [diff] [review]
Proposed patch

r=me

> -          PlacesUtils.livemarks.getLivemark({ id: this._itemId }, this);
> +          PlacesUtils.livemarks.getLivemark({ id: this._itemId })
> +                               .then(aLivemark => {
> +            this._itemType = LIVEMARK_CONTAINER;
> +            this._feedURI = aLivemark.feedURI;
> +            this._siteURI = aLivemark.siteURI;
> +            this._fillEditProperties();
> +
> +            document.documentElement
> +                    .getButton("accept").disabled = !this._inputIsValid();
> +            window.outerHeight += this._element("nameRow").boxObject.height * 2;
> +          }, () => undefined);
> +
Unnecessary blank line.

Also when I tried to subscribe to a feed the feed preview menulist drop down popupmenu is transparent like it's missing some css (broken is classic, working in modern).

Comment 3

[[e-mail]]

(In reply to Philip Chee from comment #2)
> Unnecessary blank line.
Oops.

> Also when I tried to subscribe to a feed the feed preview menulist drop down
> popupmenu is transparent like it's missing some css (broken is classic,
> working in modern).
Bug 1211708.

Comment 4

[Ian Neal]

Comment on attachment 8672415 [details] [diff] [review]
Proposed patch

r=me with Ratty's change addressed.

Comment 5

[[e-mail]]

Pushed comm-central changeset deac832faa42.

Comment 6

[[e-mail]]

Comment on attachment 8672415 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 1094900
String changes made by this patch: None

Comment 7

[[e-mail]]

Pushed comm-beta changeset 3c5164cb2013.