Closed
Bug 1213696
Opened 7 years ago
Closed 7 years ago
Can't edit livemarks
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(seamonkey2.40 fixed, seamonkey2.41 fixed)
RESOLVED
FIXED
seamonkey2.41
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
6.05 KB,
patch
|
iannbugzilla
:
review+
philip.chee
:
review+
iannbugzilla
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Because bug 1165316 missed two cases.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8672415 -
Flags: review?(philip.chee)
Attachment #8672415 -
Flags: review?(iann_bugzilla)
![]() |
||
Comment 2•7 years ago
|
||
Comment on attachment 8672415 [details] [diff] [review] Proposed patch r=me > - PlacesUtils.livemarks.getLivemark({ id: this._itemId }, this); > + PlacesUtils.livemarks.getLivemark({ id: this._itemId }) > + .then(aLivemark => { > + this._itemType = LIVEMARK_CONTAINER; > + this._feedURI = aLivemark.feedURI; > + this._siteURI = aLivemark.siteURI; > + this._fillEditProperties(); > + > + document.documentElement > + .getButton("accept").disabled = !this._inputIsValid(); > + window.outerHeight += this._element("nameRow").boxObject.height * 2; > + }, () => undefined); > + Unnecessary blank line. Also when I tried to subscribe to a feed the feed preview menulist drop down popupmenu is transparent like it's missing some css (broken is classic, working in modern).
Attachment #8672415 -
Flags: review?(philip.chee) → review+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Philip Chee from comment #2) > Unnecessary blank line. Oops. > Also when I tried to subscribe to a feed the feed preview menulist drop down > popupmenu is transparent like it's missing some css (broken is classic, > working in modern). Bug 1211708.
Comment on attachment 8672415 [details] [diff] [review] Proposed patch r=me with Ratty's change addressed.
Attachment #8672415 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Pushed comm-central changeset deac832faa42.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.41
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8672415 [details] [diff] [review] Proposed patch [Approval Request Comment] Regression caused by (bug #): 1094900 String changes made by this patch: None
Attachment #8672415 -
Flags: approval-comm-aurora?
Attachment #8672415 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 7•7 years ago
|
||
Pushed comm-beta changeset 3c5164cb2013.
status-seamonkey2.40:
--- → fixed
status-seamonkey2.41:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•