Closed Bug 1213696 Opened 5 years ago Closed 5 years ago

Can't edit livemarks

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.40 fixed, seamonkey2.41 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.41
Tracking Flags:
Tracking Status
seamonkey2.40 --- fixed
seamonkey2.41 --- fixed

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

Proposed patch
6.05 KB, patch
iann_bugzilla
: review+
philip.chee
: review+
iann_bugzilla
: approval-comm-aurora+
Details | Diff | Splinter Review 
Because bug 1165316 missed two cases.
Attached patch Proposed patch — — Splinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8672415 - Flags: review?(philip.chee)
Attachment #8672415 - Flags: review?(iann_bugzilla)
Comment on attachment 8672415 [details] [diff] [review]
Proposed patch

r=me

> -          PlacesUtils.livemarks.getLivemark({ id: this._itemId }, this);
> +          PlacesUtils.livemarks.getLivemark({ id: this._itemId })
> +                               .then(aLivemark => {
> +            this._itemType = LIVEMARK_CONTAINER;
> +            this._feedURI = aLivemark.feedURI;
> +            this._siteURI = aLivemark.siteURI;
> +            this._fillEditProperties();
> +
> +            document.documentElement
> +                    .getButton("accept").disabled = !this._inputIsValid();
> +            window.outerHeight += this._element("nameRow").boxObject.height * 2;
> +          }, () => undefined);
> +
Unnecessary blank line.

Also when I tried to subscribe to a feed the feed preview menulist drop down popupmenu is transparent like it's missing some css (broken is classic, working in modern).
Attachment #8672415 - Flags: review?(philip.chee) → review+
(In reply to Philip Chee from comment #2)
> Unnecessary blank line.
Oops.

> Also when I tried to subscribe to a feed the feed preview menulist drop down
> popupmenu is transparent like it's missing some css (broken is classic,
> working in modern).
Bug 1211708.
Comment on attachment 8672415 [details] [diff] [review]
Proposed patch

r=me with Ratty's change addressed.
Attachment #8672415 - Flags: review?(iann_bugzilla) → review+
Pushed comm-central changeset deac832faa42.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.41
Comment on attachment 8672415 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 1094900
String changes made by this patch: None
Attachment #8672415 - Flags: approval-comm-aurora?
Attachment #8672415 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.