1213845 - Figure out a sane way to enable on-screen keyboard support for Windows 8 & 8.1

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[:Gijs (he/him)]

bug 1192573 disabled the on-screen-keyboard functionality completely on windows 8 because the code now does:

  if (sPluginHasFocus ||
      !IsWin10OrLater() ||
      !Preferences::GetBool(kOskEnabled, true) ||
      sShowingOnScreenKeyboard ||
      IMEHandler::IsKeyboardPresentOnSlate()) {
    return;
  }

which means it always returns early on win8, even if you do flip the tablet mode required pref (which is checked after the above).

We should work out how to enable it properly on win8.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1213845 - enable osk support on windows 8, but hide it behind a preference, r?jaws

Bug 1213845 - enable osk support on windows 8, but hide it behind a preference, r?jaws

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8674921 [details]
MozReview Request: Bug 1213845 - enable osk support on windows 8, but hide it behind a preference, r?jaws

https://reviewboard.mozilla.org/r/22291/#review19917

::: widget/windows/WinIMEHandler.cpp:546
(Diff revision 1)
> -  // Tablet Mode is only supported on Windows 10 and higher.
> +  // Check if we're on windows 10+

This comment is redundant. Better to explain why the code is doing something than what it is doing.

::: widget/windows/WinIMEHandler.cpp:554
(Diff revision 1)
> +  // If not, check if we're disabled on pre-win10:

This comment is redundant as well, and it's presence creates a separation with the preceding if-block that I'd rather we not have.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ffa534329b36

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ffa534329b36

Comment 5

[:Gijs (he/him)]

Comment on attachment 8674921 [details]
MozReview Request: Bug 1213845 - enable osk support on windows 8, but hide it behind a preference, r?jaws

Approval Request Comment
[Feature/regressing bug #]: on-screen keyboard support on windows 8
[User impact if declined]: can't use on-screen keyboard on windows 8. We are the only major browser without support (IE and Chrome having both had support for a long time already).
[Describe test coverage new/current, TreeHerder]: no, because this depends on system hardware configuration, so we can't easily test in automation
[Risks and why]: very limited risk, we can pref off very easily if need be (specifically for win8). NB: this should be uplifted togeter with bug 1211805
[String/UUID change made/needed]: no

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8674921 [details]
MozReview Request: Bug 1213845 - enable osk support on windows 8, but hide it behind a preference, r?jaws

Adds support for a major platform, can be backed out with a pref flip. 
Approved for uplift to aurora.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since this is a newly supported feature and I'd like to make sure the uplift goes well.

Comment 8

[Carsten Book [:Tomcat]]

and this cause problems too:
grafting 309615:ffa534329b36 "Bug 1213845 - enable osk support on windows 8, but hide it behind a preference, r=jaws"
merging modules/libpref/init/all.js
warning: conflicts during merge.
merging modules/libpref/init/all.js incomplete! (edit conflicts, then use 'hg resolve --mark')
merging widget/windows/WinIMEHandler.cpp
warning: conflicts during merge.
merging widget/windows/WinIMEHandler.cpp incomplete! (edit conflicts, then use 'hg resolve --mark')

Comment 9

[:Gijs (he/him)]

This depends on bug 1210033 being uplifted.

Comment 10

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/68f165595f3a

Comment 11

[Vasilica Tamas, QA [:vtamas]]

Performed Exploratory testing on Firefox 43 beta 6 and 8 and Firefox 44.0a2 (2015-12-02) under Windows 8.1 64-bit using a Dell Xps 12 and I confirm that the On-screen keyboard is successfully displayed. More details about this testing are available in: https://goo.gl/t4VPS3

An important thing to mention would be that the OSK is still not displayed on Windows 8.1 64-bit under a Dell Inspiron 5348 All-in-one (Bug 1226522)

Based on this testing, I am marking this bug as Verified since the other issues are tracked separately.