Closed Bug 1217806 Opened 4 years ago Closed 4 years ago

Let Windows on-screen keyboard support ride the 43 train

Categories

(Firefox :: Keyboard Navigation, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 44
Tracking Status
firefox43 --- verified
firefox44 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

This is just a pref flip, but there we go.
Attachment #8678078 - Flags: review?(jaws)
https://hg.mozilla.org/mozilla-central/rev/1bce0debbdcd
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8678078 [details] [diff] [review]
flip OSK pref on release builds,

Approval Request Comment
[Feature/regressing bug #]: on-screen keyboard support on Windows 8+
[User impact if declined]: no on-screen keyboard support on Windows 8+ when 43 hits beta/release
[Describe test coverage new/current, TreeHerder]: no, because our infrastructure test machines have keyboards and because the presence of the keyboard, or lack thereof, is hard to test because it isn't a part of Firefox.
[Risks and why]: low, this is just a pref flip - we could flip it back halfway through beta (or even just disable it on win8/win8.1, but leave it in for win10) if issues did appear, and this feature has been around in Nightly for a while now. We believe all outstanding issues with it are fixed.
[String/UUID change made/needed]: no.
Attachment #8678078 - Flags: approval-mozilla-aurora?
Comment on attachment 8678078 [details] [diff] [review]
flip OSK pref on release builds,

Great, let's uplift this, on-screen keyboard support is good to have.
Attachment #8678078 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
We should give on-screen keyboard support some extra QE attention during 43 beta to make sure it looks good. Like Gijs says, if there are major problems we can turn it off at some point during beta.
Flags: qe-verify+
Flags: needinfo?(florin.mezei)
Flags: needinfo?(florin.mezei)
QA Contact: vasilica.mihasca
Do we have a meta for on-screen keyboard support? Or should I make sure any upcoming bugs are added to this one's dependencies?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #8)
> Do we have a meta for on-screen keyboard support? Or should I make sure any
> upcoming bugs are added to this one's dependencies?

Either this or bug 1007063 will be reasonable. Please also CC me and :jaws.
Flags: needinfo?(gijskruitbosch+bugs)
I confirm that the ui.osk.enabled is true by default and the on-screen keyboard is successfully displayed on Firefox 43 beta 8 (20151201152349) and Firefox 44.0a2 (2015-12-02) using Windows 8.1 64-bit and Windows 10 64-bit under a Dell Xps 12.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.