1213888 - Unable to type with Bluetooth keyboard when action bar is shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

* Attach a bluetooth keyboard to to your device
* Type in a basic text field such as bugzilla or http://pastebin.mozilla.org

Actual:
no text appears
Expected:
text appears

Using a Nexus 7 2103 w/ Logitech Tablet Keyboard

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: complete loss of functionality of bluetooth keyboards in content.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since this is a regression.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

I attached an Apple keyboard to a Nexus 4 and it worked fine. I do see some focusing issues when the action bar appears (focus moves to the action bar, so keyboard stops working until you refocus the content view).

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Regression from 10/31 nightly, range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7db14bebae9196d780b1d64d2fd32d1bda26828b&tochange=f2518b8a7b97b5bb477e94bc9131584007aac887

Kats, I think bug 1197811 is most relevant. Maybe the fix for that bug changed the way focus is handled? Right now when the action bar is shown during text input, the focus moves away from the layer view, so layer view no longer receives any key events.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

That bug didn't explicitly do anything with focus, but it did change the LayerView from being a FrameLayout to a ScrollView with a dummy field at the top (and the content area sitting vertically below it). It could be that the dummy field is getting focus instead of the content area. You could try listening for focus changes on mFillerView and see if it's getting focus in this scenario, or try making it unfocusable somehow to see if that fixes the problem.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Block LayerView descendants from interfering with focus (v1)

Using a hardware keyboard makes Android leave "touch mode", and when
leaving touch mode from a ViewGroup that prefers descendant
focusability, which is what a ScrollView is, Android will shift the
focus to the next available View, and cause our LayerView to lose focus.
The fix is to set the descendant focusability to blocking.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8681313 [details] [diff] [review]
Block LayerView descendants from interfering with focus (v1)

Review of attachment 8681313 [details] [diff] [review]:
-----------------------------------------------------------------

Bit of a rubber-stamp :)

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a3d50bf4d8e

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/dec44b4525eb

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8681313 [details] [diff] [review]
Block LayerView descendants from interfering with focus (v1)

Approval Request Comment

[Feature/regressing bug #]: Bug 1197811

[User impact if declined]: Unable to use hardware keyboards in Fennec under some scenarios

[Describe test coverage new/current, TreeHerder]: Locally

[Risks and why]: Very small; one line patch is very unlikely to have other impact.

[String/UUID change made/needed]: None

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dec44b4525eb

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/dec44b4525eb

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8681313 [details] [diff] [review]
Block LayerView descendants from interfering with focus (v1)

Simple fix, let's take it for Aurora44.

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Kevin, would you be able to confirm that the fix works as expected on a latest Nightly build? Should we consider adding this to our QE sign off test plan done by SoftVision team? Thanks!

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/72d666f8e818

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/72d666f8e818

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8681313 [details] [diff] [review]
Block LayerView descendants from interfering with focus (v1)

Taking it in 43 beta 2 too.
Please also land the test.

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/90cae878a97e

Comment 19

[u421692]

Tested on Nexus 9 (Android 6.0) and Apple Wireless Keyboard on https://pastebin.mozilla.org/
On Firefox 43 Beta 1 I was able to reproduce this issue
Verified as fixed on Firefox 43 Beta 2, on latest Aurora and Nightly