1213898 - Back button is invisible

Status: RESOLVED DUPLICATE of bug 1210930

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Ben Francis [:benfrancis]]

STR:
* Load a web page in a browser window
* Follow a link to another page

Expected;
* Back button visible

Actual:
* Blank space where the back button should be. Still clickable.

[Blocking Requested - why for this release]:
Broken looking UI

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

I'm unable to reproduce this with last night's build running the latest gaia.

Ben, what version are you using? What color is the theme-color? Is it a private window?

Comment 2

[Ben Francis [:benfrancis]]

Master, on guardian.co.uk which has a blue theme-color and uses white icons.

Comment 3

[Chris Lord [:cwiiis]]

This only happens with dark theme colors (so light icons).

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] jedireza:browser-chrome-dark-theme-images > mozilla-b2g:master

Comment 5

[Reza Akhavan [:jedireza]]

Comment on attachment 8672824 [details] [review]
[gaia] jedireza:browser-chrome-dark-theme-images > mozilla-b2g:master

This was happening to sites with dark themes (the guardian, yahoo finance) and also with private browser windows. The image paths for both back and forward buttons were incorrect.

It looks like a partially baked change from refactoring CSS in this PR:
https://github.com/mozilla-b2g/gaia/pull/32037

The CSS styles were changed and light image files renamed, but they forgot to rename the dark image files.

In my PR I renamed the dark image files names.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

good investigation Reza

Comment 7

[Reza Akhavan [:jedireza]]

Bug 1210930 will also resolve this and was already in flight. There is an UI test in the works too which is a good idea.

Comment 8

[Gregor Wagner [:gwagner]]

Please verify once the dup is fixed.