1214386 - mozregression should show stdout with a specific flag (not mixed in the debug flag)

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Benoit Girard (:BenWa)]

I'm trying to do a bisection for bug 1214261 but I'm missing useful information that is sent to stdout (layers.dump and the GFX warnings). I can't reliable bisect without this information.

Comment 1

[Julien Pagès (:parkouss)]

You will see the console output by adding:

> --log-mach-level debug

There is no way for now to activate console output only (without enabling all debug traces).

Comment 2

[Julien Pagès (:parkouss)]

Closing this as WONTFIX, since I think this is working (please reopen the bug if I'm making a mistake).

Still I would like to add a specific logging flag one day (that would print stdout, but not the whole debugging output). We first need to look at bug 1199902.

Comment 3

[Benoit Girard (:BenWa)]

Why close as WOTNFIX then? Why not leave it until we an fix this? The current flag isn't isn't clear. It looks like it's a mozregression debug option.

Comment 4

[Julien Pagès (:parkouss)]

Right, make sense - thanks.

Comment 5

[William Lachance (:wlach)]

Personally I think we should just print stdout by default. It doesn't really hurt.

Comment 6

[Julien Pagès (:parkouss)]

(In reply to William Lachance (:wlach) from comment #5)
> Personally I think we should just print stdout by default. It doesn't really
> hurt.

Well, I'm not sure. I think being able to see efficiently what was the previous steps (including pushlogurls) is something great.

Anyway the new option will be configurable, from config file and command line - so that's just an application default that we have to choose, each user would be able to configure the way he wants. So I'm not strongly opposed to that.

Comment 7

[Julien Pagès (:parkouss)]

Attachment: process logging

The following PR address this bug, and the closely related bug 1225548 (two separate commits).

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8688843 [details] [review]
process logging

I have a few concerns. Feel free to ask for re-review after addressing or telling me why they shouldn't be addressed. :)

Comment 9

[Julien Pagès (:parkouss)]

Attachment: log process

So, basically I just renamed 0 and 1 possible values to none and stdout.

Makes a lot more sense, thanks! But I would like to keep the ability to pass a value in there, for the reasons mentioned in the other PR.

BTW, sorry for the mess with the PRS. :)

Comment 10

[William Lachance (:wlach)]

Comment on attachment 8690002 [details] [review]
log process

Did you remember to update the PR? It's still saying 0 and 1.

Comment 11

[Julien Pagès (:parkouss)]

Yes, I did but only in the second commit, I was too lazy to also fix the first one.

https://github.com/parkouss/mozregression/commit/3575f5ae333050290bcf0418a949604709c2140d

I updated the commit message, it is ok for me. If we have to cherry pick the commits (which is unlikely to happen), hopefully the message will help to remember that. If you really want me to also fix the first commit, I can do that. :)

Comment 12

[William Lachance (:wlach)]

Comment on attachment 8690002 [details] [review]
log process

Ok!

Comment 13

[Julien Pagès (:parkouss)]

Cool. :) Landed in https://github.com/mozilla/mozregression/commit/94dc5324f915653c57c485ac335093e9000b27e4.