1214713 - (SQLite3.9.1) Upgrade to SQLite 3.9.1

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[NVD]

https://www.sqlite.org/news.html

https://www.sqlite.org/releaselog/3_9_0.html

"SQLite version 3.9.0 is a regularly schedule maintenance release. Key changes include:

    Begin using semantic versioning.
    JSON SQL functions
    The FTS5 full-text search engine
    Support for indexes on expressions
    Support for table-valued functions 

See the change log for a long and more complete list of changes. "

Comment 1

[Marco Bonardo [:mak]]

Thanks for filing.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Mak says there's no rush on this, so I'll take this next week on the off chance there are any critical issues found in the mean time. I did a Try run for drh a few days ago of a recent amalgamation without issue, so I don't expect this to have any landing difficulties.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Do we want to enable json1 or FTS5 by default or save them for another bug?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Vanilla 3.9.1 is looking good on Try (and fine locally).
https://treeherder.mozilla.org/#/jobs?repo=try&revision=398f5fa40dde&group_state=expanded

Comment 5

[Marco Bonardo [:mak]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #3)
> Do we want to enable json1 or FTS5 by default or save them for another bug?

We don't enable features until someone in the project actually needs them with good reasons.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.9.1

Good on Try, good tested locally, and seems to be sticking upstream. Let's get this landed.

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 8676829 [details] [diff] [review]
Upgrade to SQLite 3.9.1

Review of attachment 8676829 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/836d8a2ea713

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/836d8a2ea713