Closed
Bug 1214772
Opened 10 years ago
Closed 9 years ago
Implement .waitUntil() on FetchEvent
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: bkelly, Assigned: ehsan.akhgari)
References
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
5.41 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
4.12 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
FetchEvent now extends ExtendableEvent which gives it a waitUntil() method:
https://github.com/slightlyoff/ServiceWorker/commit/ff93a4630866dcb9080bdf83fa5b82ddfed593a1
Reporter | ||
Comment 1•9 years ago
|
||
Chrome actually implements this already and I see sites needing it all over the place. I think we need it for v1 because devs are not going to try to feature detect this.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Updated•9 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8678844 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8679063 -
Flags: review?(bkelly)
Reporter | ||
Updated•9 years ago
|
Attachment #8679063 -
Flags: review?(bkelly) → review+
Comment 4•9 years ago
|
||
Please also remove mPromise and GetPromise from FetchEvent, these were used to extend the sw's lifetime when calling respondWith. I think respondWith should call waitUntil internally.
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Cătălin Badea (:catalinb) from comment #4)
> Please also remove mPromise and GetPromise from FetchEvent, these were used
> to extend the sw's lifetime when calling respondWith. I think respondWith
> should call waitUntil internally.
Good point! Filed bug 1218621.
![]() |
||
Comment 6•9 years ago
|
||
Comment on attachment 8678844 [details] [diff] [review]
Make FetchEvent inherit from ExtendableEvent
r=me
Attachment #8678844 -
Flags: review?(bzbarsky) → review+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ac8844b56a54
https://hg.mozilla.org/mozilla-central/rev/908842d5007b
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment 9•9 years ago
|
||
The FetchEvent page already states that it inherits from ExtendableEvent, but I've added an explicit link to the waitUntil() page, just to be clear:
https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent
And a note was already added to the release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/44#Service_Workers
So we're all good.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•