1214772 - Implement .waitUntil() on FetchEvent

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

FetchEvent now extends ExtendableEvent which gives it a waitUntil() method:

https://github.com/slightlyoff/ServiceWorker/commit/ff93a4630866dcb9080bdf83fa5b82ddfed593a1

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Chrome actually implements this already and I see sites needing it all over the place.  I think we need it for v1 because devs are not going to try to feature detect this.

Comment 2

[(no longer active)]

Attachment: Make FetchEvent inherit from ExtendableEvent

Comment 3

[(no longer active)]

Attachment: Part 1: Move the declaration of FetchEvent to after that of ExtendableEvent

Comment 4

[Cătălin Badea (:catalinb)]

Please also remove mPromise and GetPromise from FetchEvent, these were used to extend the sw's lifetime when calling respondWith. I think respondWith should call waitUntil internally.

Comment 5

[(no longer active)]

(In reply to Cătălin Badea (:catalinb) from comment #4)
> Please also remove mPromise and GetPromise from FetchEvent, these were used
> to extend the sw's lifetime when calling respondWith. I think respondWith
> should call waitUntil internally.

Good point!  Filed bug 1218621.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8678844 [details] [diff] [review]
Make FetchEvent inherit from ExtendableEvent

r=me

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac8844b56a54
https://hg.mozilla.org/integration/mozilla-inbound/rev/908842d5007b

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ac8844b56a54
https://hg.mozilla.org/mozilla-central/rev/908842d5007b

Comment 9

[Chris Mills [:cmills]]

The FetchEvent page already states that it inherits from ExtendableEvent, but I've added an explicit link to the waitUntil() page, just to be clear:

https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent 

And a note was already added to the release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/44#Service_Workers

So we're all good.