1214955 - Automatically localize all string properties in manifest.json

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P2)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This is a follow-up for bug 1197422.

Comment 1

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1214955: [webext] Automatically localize all localizable manifest properties. r?billm

Review commit: https://reviewboard.mozilla.org/r/36975/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36975/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8724319 [details]
MozReview Request: Bug 1214955: [webext] Automatically localize all localizable manifest properties. r?billm

https://reviewboard.mozilla.org/r/36975/#review33795

::: browser/components/extensions/schemas/browser_action.json:20
(Diff revision 1)
> +              "default_icon": {

Don't you want this to be localized?

::: browser/components/extensions/schemas/page_action.json:20
(Diff revision 1)
> +              "default_icon": {

Don't you want this to be localized?

::: toolkit/components/extensions/Extension.jsm:658
(Diff revision 1)
> +        preprocessors: {},

How about we always add "localize" to preprocessors, but it's the identity function if we don't have locale data?

::: toolkit/components/extensions/Schemas.jsm:281
(Diff revision 1)
> +  preprocess(value, context) {

Please extend the XPCShell test to test preprocessor stuff.

::: toolkit/components/extensions/Schemas.jsm:282
(Diff revision 1)
> +    if (this.preprocessor in context.preprocessors) {

This seems prone to error. I'd rather we throw an exception if this.preprocessor is defined and it's not in context.preprocessors. How about just |if (this.preprocessor)|?

Comment 3

[Kris Maglione [:kmag]]

https://reviewboard.mozilla.org/r/36975/#review33795

> Don't you want this to be localized?

I'm not sure. I was originally planning to, but Chrome doesn't localize icon properties, and we don't localize extension icons in either kind of install manifest, so I decided to skip it.

> This seems prone to error. I'd rather we throw an exception if this.preprocessor is defined and it's not in context.preprocessors. How about just |if (this.preprocessor)|?

Yeah, that makes sense.

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/4c924e5c274980190d1e897fd2fd8cc3c87da0f0
Bug 1214955: [webext] Automatically localize all localizable manifest properties. r=billm

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4c924e5c2749

Comment 6

[Kris Maglione [:kmag]]

I'm not sure what the best way to document these is. Perhaps some kind of inline tag to indicate properties that are localized, similar to the [optional] tag?

The following properties currently support localization:

name
short_name
description
creator
homepage_url
browser_action.default_title
browser_action.default_popup
page_action.default_title
page_action.default_popup

Comment 7

[Will Bamberg [:wbamberg]]

I've added a note in the docs page for every manifest key that has "preprocess": "localize" in its schema entry.