1214989 - Remove MediaDecoder::Init()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rc-complete.

Since MediaDecoder::Init() always returns true now, we can move the code into the constructor to enforce more invariants.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b06a04cd8510

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1214989. Part 1 - add MediaDecoderOwner to the constructors of MediaDecoder and sub-classes. r=gerald.

Bug 1214989. Part 1 - add MediaDecoderOwner to the constructors of MediaDecoder and sub-classes. r=gerald.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1214989. Part 2 - add MediaDecoderOwner to Clone() and overrides. r=gerald.

Bug 1214989. Part 2 - add MediaDecoderOwner to Clone() and overrides. r=gerald.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1214989. Part 3 - remove MediaDecoder::Init() and its callers. r=gerald.

Bug 1214989. Part 3 - remove MediaDecoder::Init() and its callers. r=gerald.

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8674040 [details]
MozReview Request: Bug 1214989. Part 1 - add MediaDecoderOwner to the constructors of MediaDecoder and sub-classes. r=gerald.

https://reviewboard.mozilla.org/r/22185/#review19777

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8674041 [details]
MozReview Request: Bug 1214989. Part 2 - add MediaDecoderOwner to Clone() and overrides. r=gerald.

https://reviewboard.mozilla.org/r/22187/#review19779

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8674042 [details]
MozReview Request: Bug 1214989. Part 3 - remove MediaDecoder::Init() and its callers. r=gerald.

https://reviewboard.mozilla.org/r/22189/#review19781

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://reviewboard.mozilla.org/r/22183/#review19783

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22d4ee3b8328
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dbeeab11633
https://hg.mozilla.org/integration/mozilla-inbound/rev/37db54da9eec

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/22d4ee3b8328
https://hg.mozilla.org/mozilla-central/rev/9dbeeab11633
https://hg.mozilla.org/mozilla-central/rev/37db54da9eec