Closed Bug 1214989 Opened 4 years ago Closed 4 years ago

Remove MediaDecoder::Init()

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

Per https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rc-complete.

Since MediaDecoder::Init() always returns true now, we can move the code into the constructor to enforce more invariants.
Assignee: nobody → jwwang
Bug 1214989. Part 1 - add MediaDecoderOwner to the constructors of MediaDecoder and sub-classes. r=gerald.
Attachment #8674040 - Flags: review?(gsquelart)
Bug 1214989. Part 2 - add MediaDecoderOwner to Clone() and overrides. r=gerald.
Attachment #8674041 - Flags: review?(gsquelart)
Bug 1214989. Part 3 - remove MediaDecoder::Init() and its callers. r=gerald.
Attachment #8674042 - Flags: review?(gsquelart)
Attachment #8674040 - Flags: review?(gsquelart) → review+
Comment on attachment 8674040 [details]
MozReview Request: Bug 1214989. Part 1 - add MediaDecoderOwner to the constructors of MediaDecoder and sub-classes. r=gerald.

https://reviewboard.mozilla.org/r/22185/#review19777
Comment on attachment 8674041 [details]
MozReview Request: Bug 1214989. Part 2 - add MediaDecoderOwner to Clone() and overrides. r=gerald.

https://reviewboard.mozilla.org/r/22187/#review19779
Attachment #8674041 - Flags: review?(gsquelart) → review+
Comment on attachment 8674042 [details]
MozReview Request: Bug 1214989. Part 3 - remove MediaDecoder::Init() and its callers. r=gerald.

https://reviewboard.mozilla.org/r/22189/#review19781
Attachment #8674042 - Flags: review?(gsquelart) → review+
Thanks for the review!
Blocks: 1215023
Blocks: 1216031
You need to log in before you can comment on or make changes to this bug.