1215023 - Remove null check of mOwner from MediaDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

After bug 1214989 is landed, we can enforce more invariants.

Since mOwner is initialized in the constructor, we can make it a const member and remove null checks spreading across the entire class.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8256579921d

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1215023. Part 1 - make MediaDecoder::mOwner a const member. We will check mShuttingDown before calling functions of mOwner.

Bug 1215023. Part 1 - make MediaDecoder::mOwner a const member. We will check mShuttingDown before calling functions of mOwner.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1215023. Part 2 - remove null check of mOwner. We check mShuttingDown to know whether it is valid to call functions of mOwner.

Bug 1215023. Part 2 - remove null check of mOwner. We check mShuttingDown to know whether it is valid to call functions of mOwner.

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8675485 [details]
MozReview Request: Bug 1215023. Part 2 - remove null check of mOwner. We check mShuttingDown to know whether it is valid to call functions of mOwner.

https://reviewboard.mozilla.org/r/22377/#review19973

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8675484 [details]
MozReview Request: Bug 1215023. Part 1 - make MediaDecoder::mOwner a const member. We will check mShuttingDown before calling functions of mOwner.

https://reviewboard.mozilla.org/r/22375/#review19977

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5de7b460e380
https://hg.mozilla.org/integration/mozilla-inbound/rev/2775215bf67e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5de7b460e380
https://hg.mozilla.org/mozilla-central/rev/2775215bf67e

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5de7b460e380
https://hg.mozilla.org/mozilla-central/rev/2775215bf67e