Remove null check of mOwner from MediaDecoder

RESOLVED FIXED in Firefox 44

Status

()

P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
After bug 1214989 is landed, we can enforce more invariants.

Since mOwner is initialized in the constructor, we can make it a const member and remove null checks spreading across the entire class.
(Assignee)

Updated

3 years ago
Assignee: nobody → jwwang
(Assignee)

Updated

3 years ago
Depends on: 1214989
(Assignee)

Comment 2

3 years ago
Created attachment 8675484 [details]
MozReview Request: Bug 1215023. Part 1 - make MediaDecoder::mOwner a const member. We will check mShuttingDown before calling functions of mOwner.

Bug 1215023. Part 1 - make MediaDecoder::mOwner a const member. We will check mShuttingDown before calling functions of mOwner.
(Assignee)

Comment 3

3 years ago
Created attachment 8675485 [details]
MozReview Request: Bug 1215023. Part 2 - remove null check of mOwner. We check mShuttingDown to know whether it is valid to call functions of mOwner.

Bug 1215023. Part 2 - remove null check of mOwner. We check mShuttingDown to know whether it is valid to call functions of mOwner.
Attachment #8675485 - Flags: review?(kinetik)
Comment on attachment 8675485 [details]
MozReview Request: Bug 1215023. Part 2 - remove null check of mOwner. We check mShuttingDown to know whether it is valid to call functions of mOwner.

https://reviewboard.mozilla.org/r/22377/#review19973
Attachment #8675485 - Flags: review?(kinetik) → review+
Comment on attachment 8675484 [details]
MozReview Request: Bug 1215023. Part 1 - make MediaDecoder::mOwner a const member. We will check mShuttingDown before calling functions of mOwner.

https://reviewboard.mozilla.org/r/22375/#review19977
Attachment #8675484 - Flags: review+
(Assignee)

Comment 6

3 years ago
Thanks for the review!
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/5de7b460e380
https://hg.mozilla.org/mozilla-central/rev/2775215bf67e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(Assignee)

Updated

3 years ago
Blocks: 1217653
You need to log in before you can comment on or make changes to this bug.