Closed Bug 1214997 Opened 8 years ago Closed 8 years ago

Use MozPromise in MediaCodecProxy and OMXCodecProxy

Categories

(Core :: Audio/Video: Playback, defect, P2)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 3 obsolete files)

patch - Use MozPromise in MediaCodecProxy and OMXCodecProxy
53.90 KB, patch
sotaro
: review+
Details | Diff | Splinter Review 
It seems nice to use MozPromise in MediaSystemResourceClient.
See Also: → 1210045
Priority: -- → P2
Assignee: nobody → sotaro.ikeda.g
Depends on: 1219140
Summary: Return MozPromise by MediaSystemResourceClient::Acquire() → Use MozPromise in MediaCodecProxy and OMXCodecProxy
(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> It seems nice to use MozPromise in MediaSystemResourceClient.

bug's scope was changed as to use MozPromise in MediaCodecProxy and OMXCodecProxy.
Rebased.
Attachment #8681012 - Attachment is obsolete: true
Correct patch.
Attachment #8684732 - Attachment is obsolete: true
Attachment #8684735 - Flags: review?(bwu)
Comment on attachment 8684735 [details] [diff] [review]
patch - Use MozPromise in MediaCodecProxy and OMXCodecProxy

Review of attachment 8684735 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me!

::: dom/media/omx/MediaCodecProxy.cpp
@@ +115,5 @@
>    }
>    return false;
>  }
>  
> +RefPtr<MediaCodecProxy::CodecPromise> 

remove trailing space.

::: dom/media/omx/MediaCodecReader.h
@@ +172,5 @@
>    MozPromiseRequestHolder<MediaResourcePromise> mMediaResourceRequest;
>    MozPromiseHolder<MediaResourcePromise> mMediaResourcePromise;
>  
> +  MozPromiseRequestHolder<android::MediaCodecProxy::CodecPromise> mVideoCodecRequest;
> +

Now we have mMediaResourceRequest, mMediaResourcePromise, and mVideoCodecRequest to handle the request for video codec use. It looks a little complicated and there should be a simpler way to do it. However, we are going to remove MediaCodecReader in bug 1198576, so it would be no need to simplify this codes.
Attachment #8684735 - Flags: review?(bwu) → review+
(In reply to Blake Wu [:bwu][:blakewu] from comment #5)
> 
> Now we have mMediaResourceRequest, mMediaResourcePromise, and
> mVideoCodecRequest to handle the request for video codec use. It looks a
> little complicated and there should be a simpler way to do it. However, we
> are going to remove MediaCodecReader in bug 1198576, so it would be no need
> to simplify this codes.

Thanks for the review. I almost did the the above suggestion, but stopped to do it because of the above reason.
Apply the comment. Carry "r=bwu".
Attachment #8684735 - Attachment is obsolete: true
Attachment #8685269 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/c0ccc4c5af5e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.