1215027 - Reboot when enabling BasicCompositor on gonk

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

When enabling BasicCompositor on gonk, b2g process was crashed during booting.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix EndFrameForExternalComposition()

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8674120 [details] [diff] [review]
patch - Fix EndFrameForExternalComposition()

Review of attachment 8674120 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you add the warning

::: gfx/layers/basic/BasicCompositor.h
@@ +89,5 @@
>                            const gfx::Rect& aRenderBounds,
>                            gfx::Rect *aClipRectOut = nullptr,
>                            gfx::Rect *aRenderBoundsOut = nullptr) override;
>    virtual void EndFrame() override;
> +  virtual void EndFrameForExternalComposition(const gfx::Matrix& aTransform) override { }

If this is used it should be implemented.
Please add NS_WARNING("BasicCOmpositor::EndFrameForExternalComposition - not implemented!"); or something like that.
Or even better, file a bug and reference the bug in the warning.

Comment 3

[Sotaro Ikeda [:sotaro]]

Thanks. I created Bug 1215364.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix EndFrameForExternalComposition()

Apply the comment.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64a06f8a10d2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64a06f8a10d2