Implement BasicCOmpositor::EndFrameForExternalComposition

RESOLVED FIXED in Firefox 44

Status

()

Core
Graphics: Layers
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1215027 +++

Need to implement BasicCOmpositor::EndFrameForExternalComposition()
(Assignee)

Updated

2 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

2 years ago
EndFrameForExternalComposition() is called when Composer2D does full hw composition.
  https://dxr.mozilla.org/mozilla-central/source/gfx/layers/composite/LayerManagerComposite.cpp#703

If there is a target for rendering, Composer2D is not used. And when EndFrameForExternalComposition() is called, Compositor::BeginFrame() is not called. It means that Compositor does not even start composition when EndFrameForExternalComposition() is called. Therefore we do not have a thing to do in the function except cleaning up temporary resources.
(Assignee)

Comment 2

2 years ago
Created attachment 8677249 [details] [diff] [review]
patch - Implement BasicCOmpositor::EndFrameForExternalComposition
(Assignee)

Updated

2 years ago
Attachment #8677249 - Flags: review?(nical.bugzilla)

Updated

2 years ago
Attachment #8677249 - Flags: review?(nical.bugzilla) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d7915821d9ca
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.