1215042 - Home screen radio button selection should not change when tapping on home screen name

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Teri Wen [:twen]]

When tapping on home screen name, radio button selection jumps. 
Even though the selection moves back when you return to the selection page, the radio button selection should not move at all. 

[Repro Steps]:
Prereq - Home Screen selects Default Home Screen
1. Settings-> Home Screens -> Change Home Screen
2. Tap on New Home Screen name


[Actual Result]: 
Taps into Home screen details page and radio button is selected for a second

[Expected Result]:
Radio button selection should not move

[Build Info]:
Build ID               20151014225836
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151014.221548
Firmware Date          Wed Oct 14 22:15:56 UTC 2015
Bootloader             s1

Comment 1

[Chris Lord [:cwiiis]]

gmarty, think you could take a look?

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1215042-Home-screen-radio-button-selection-should-not-change-when-tapping-on-home-screen-name > mozilla-b2g:master

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8674173 [details] [review]
[gaia] gmarty:Bug-1215042-Home-screen-radio-button-selection-should-not-change-when-tapping-on-home-screen-name > mozilla-b2g:master

Hi Fred. Can you take a look at this minor change?

Comment 4

[[e-mail]]

Comment on attachment 8674173 [details] [review]
[gaia] gmarty:Bug-1215042-Home-screen-radio-button-selection-should-not-change-when-tapping-on-home-screen-name > mozilla-b2g:master

Thanks for the patch, please also update the event name in comment

Comment 5

[Guillaume Marty [:gmarty]]

Landed in https://github.com/mozilla-b2g/gaia/commit/8a3f4ee540ebb5afbdc00047910cc689a2f400a2

Comment 6

[Teri Wen [:twen]]

Verified fixed on m-c.

Build ID               20151015193337
Gaia Revision          8ea9029190af2ffeb04dcd97b323738125e31a0e
Gaia Date              2015-10-15 14:30:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d374d16cbb251c9dac5af69f8e186e821ce82fe2
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151015.185317
Firmware Date          Thu Oct 15 18:53:25 UTC 2015
Bootloader             s1