1215200 - Upgrade Mozilla 44 to use NSPR 4.10.10 and NSS 3.20.1

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Kai Engert [:KaiE:]]

Let's upgrade Mozilla 44 to use NSPR 4.10.10 and NSS 3.20.1.

David, if you agree, can I go ahead and land the release candidate snapshots into mozilla-inbound? Thanks

Comment 1

[Dana Keeler (she/her) [:keeler]]

r=me

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b46b688e6295

Comment 3

[Kai Engert [:KaiE:]]

checked in release candidate tags:

Comment 4

[Nigel Babu [:nigelb]]

You have bustage like the following:


78[1G[J[34m 2:24.25(B[m /home/worker/workspace/gecko/xpcom/ds/nsPersistentProperties.cpp:31:119: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
78[1G[J[34m 2:24.25(B[m /home/worker/workspace/gecko/xpcom/ds/nsPersistentProperties.cpp:45:119: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

Comment 5

[Nicholas Nethercote [inactive]]

> 78[1G[J[34m 2:24.25(B[m
> /home/worker/workspace/gecko/xpcom/ds/nsPersistentProperties.cpp:31:119:
> error: comparison between signed and unsigned integer expressions
> [-Werror=sign-compare]
> 78[1G[J[34m 2:24.25(B[m
> /home/worker/workspace/gecko/xpcom/ds/nsPersistentProperties.cpp:45:119:
> error: comparison between signed and unsigned integer expressions
> [-Werror=sign-compare]

Those lines use the PL_ARENA_ALLOCATE macro.

Comment 6

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92dc9ab424bdde398c107b8ce4f91869b81a87ae
Backed out changeset b46b688e6295 (bug 1215200) for build bustage ON A CLOSED TREE

Comment 7

[Kai Engert [:KaiE:]]

Thank you.
The NSS continous integration had not caught this problem.

We got a fix and I've started a try run at
https://treeherder.mozilla.org/#/jobs?repo=try&revision=638b11d303d7

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a58db3e939c

Comment 9

[Kai Engert [:KaiE:]]

Try run looks ok.
Relanding with fix, NSPR_4_10_10_RC1 and NSS_3_20_1_RC0

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8a58db3e939c

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8a58db3e939c

Comment 12

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23431dd48594

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/23431dd48594