Closed Bug 1215234 Opened 6 years ago Closed 6 years ago

update MP4Metadata.rs to mp4parse v0.1.0

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(3 files)

Version bump so we can start hooking up the C++ side.
This turned out not to have important changes, but I'd rather build against what we're building against out-of-tree.
Attachment #8674398 - Flags: review?(kinetik)
Attachment #8674415 - Flags: review?(kinetik)
gtest needs updating for the new read_box_from_buffer signature.
Attachment #8674416 - Flags: review?(kinetik)
Attachment #8674398 - Flags: review?(kinetik) → review+
Comment on attachment 8674416 [details] [diff] [review]
Update gtest for mp4parse v0.1.0

Any idea why it fails?
Attachment #8674416 - Flags: review?(kinetik) → review+
Attachment #8674415 - Flags: review?(kinetik) → review+
(In reply to Matthew Gregan [:kinetik] from comment #4)

> Any idea why it fails?

I think it might be EOF error catch clobbering something? But not sure. The dump.cc example in the mp4parse-rust repo fails similarly. It only loaded the first 4k by default, but (a) that should be enough and (b) it still fails if I raise the chunk size to 40M.
Blocks: 1161350
Blocks: 1219452
You need to log in before you can comment on or make changes to this bug.