1215296 - QueryProgramInfo doesn't handle interface fields very well

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

It gets confused by the name mappings not showing from ShGetUniforms

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I filed an ANGLE bug about this but it was won't fixed: https://code.google.com/p/angleproject/issues/detail?id=1181

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: WIP to get things working

Comment 3

[Jeff Muizelaar [:jrmuizel]]

I have this working now.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Also look in interface blocks when looking for uniforms

This approach is more inline with what was suggested by the ANGLE people.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8685058 [details] [diff] [review]
Also look in interface blocks when looking for uniforms

Review of attachment 8685058 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLShaderValidator.cpp
@@ +392,5 @@
>          return true;
>      }
>  
> +    const std::vector<sh::InterfaceBlock>& interfaces = *ShGetInterfaceBlocks(mHandle);
> +    for (const auto &interface : interfaces) {

& against type.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6cbee6147340

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6cbee6147340