Closed Bug 1215459 Opened 9 years ago Closed 9 years ago

[TV] Show visual feedback and disable 'Sign in' button while enabling Sync

Categories

(Firefox OS Graveyard :: Sync, defect, P3)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(b2g-v2.5 fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

(Keywords: late-l10n, Whiteboard: [partner-cherry-pick])

Attachments

(2 files)

[gaia] ferjm:bug1215459.visual.feedback.signin > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yifan
: review+
tchen
: feedback+
mpotharaju
: approval-gaia-v2.5+
Details | Review
[gaia] ferjm:bug1215459.followup > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review
No description provided.
Assignee: nobody → ferjmoreno
Blocks: fxos-sync
Target Milestone: --- → FxOS-S10 (30Oct)
Target Milestone: FxOS-S10 (30Oct) → FxOS-S11 (13Nov)
Priority: -- → P3
Target Milestone: FxOS-S11 (13Nov) → FxOS-S10 (30Oct)
Summary: Show visual feedback and disable 'Get started' button while enabling Sync → [TV] Show visual feedback and disable 'Sign in' button while enabling Sync
Keywords: late-l10n
Comment on attachment 8681274 [details] [review] [gaia] ferjm:bug1215459.visual.feedback.signin > mozilla-b2g:master I didn't add any spinner or progress icon as I couldn't find such a thing for the browser or smart-buttons. What I did was to change the label of the buttons from 'Sign in' to 'Signing in' and disable them. This gives good feedback to the user about what's going on. However it is not on the UX spec and it introduces a new string.
Attachment #8681274 - Flags: review?(yliao)
Comment on attachment 8681274 [details] [review] [gaia] ferjm:bug1215459.visual.feedback.signin > mozilla-b2g:master Tori, could we add the new string 'signing in' in 2.5? Thanks!
Attachment #8681274 - Flags: feedback?(tchen)
Hi Yifan, I can add it, could you paste the new string here?
Flags: needinfo?(yliao)
Comment on attachment 8681274 [details] [review] [gaia] ferjm:bug1215459.visual.feedback.signin > mozilla-b2g:master Thanks! @Tori, "fxsync-signing=Signing in..." Thank you.
Flags: needinfo?(yliao)
Attachment #8681274 - Flags: review?(yliao) → review+
Comment on attachment 8681274 [details] [review] [gaia] ferjm:bug1215459.visual.feedback.signin > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1194108 [User impact] if declined: After signing in fx account a user will have to wait for several seconds without any visual indication. [Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8f4e354ec656502c99c0d5cd586032d8dd7fc991 [Risk to taking this patch] (and alternatives if risky): none [String changes made]: fxsync-signing=Signing in...
Attachment #8681274 - Flags: approval-gaia-v2.5?
https://github.com/mozilla-b2g/gaia/commit/baebda9e24e6ac4a401114dd57c3c60aa0132e62
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Can you land a quick follow-up replacing "..." with the proper utf-8 character "…"? That's what all Mozilla software does, Gaia included. No need to update the string ID.
Flags: needinfo?(ferjmoreno)
Attachment #8681274 - Flags: feedback?(tchen) → feedback+
Whiteboard: [partner-cherry-pick]
Comment on attachment 8681274 [details] [review] [gaia] ferjm:bug1215459.visual.feedback.signin > mozilla-b2g:master Approved for 2.5 uplift. Thanks
Attachment #8681274 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
To avoid any confusion already happened in other bugs, this is *already* on v2.5 https://github.com/mozilla-b2g/gaia/commits/v2.5/shared/locales/firefox_sync/firefox_sync.en-US.properties
(In reply to Francesco Lodolo [:flod] from comment #12) > To avoid any confusion already happened in other bugs, this is *already* on > v2.5 > https://github.com/mozilla-b2g/gaia/commits/v2.5/shared/locales/firefox_sync/ > firefox_sync.en-US.properties updating flag
status-b2g-v2.5: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: