1215469 - Create a Gaia UI test that exercises the first run dialog in the browser

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

In bug 1205042, a first run popup appears in the browser, that mentions something about tracking protection.
We've disabled that dialog in bug 1215191, so our Gaia UI tests don't fail because of it.

But we should create a test for this feature, to make sure it doesn't break.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1215469 > mozilla-b2g:master

Comment 2

[No-Jun Park [:njpark]]

Comment on attachment 8678592 [details] [review]
[gaia] mwargers:1215469 > mozilla-b2g:master

Other than the small nit to replace the sleep() call, it looks good to me.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8678592 [details] [review]
[gaia] mwargers:1215469 > mozilla-b2g:master

It's a good test, thanks for adding it. There is one class relationship we can make clearer. There's also some checks that are done twice. Making these changes would likely make the intent clearer, I think.

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 8678592 [details] [review]
[gaia] mwargers:1215469 > mozilla-b2g:master

I updated the pull request and removed FullscreenDialog completely here and use is_element_present instead. This seems much cleaner to me. What do you think?

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8678592 [details] [review]
[gaia] mwargers:1215469 > mozilla-b2g:master

Good call! The end of the test looks nicer.

Comment 6

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/9861bfcc00fdb98a8811d5ad422a34009b3d9661