Closed Bug 1205042 Opened 6 years ago Closed 6 years ago

[Browser] Tracking Protection FTE Popup

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+)

RESOLVED FIXED
blocking-b2g 2.5+

People

(Reporter: tif, Assigned: apastor)

References

Details

(Whiteboard: [systemsfe])

User Story

Visual Spec for TP FTE Pop up Pg 13:
https://mozilla.box.com/s/qdb9m1dt365mlu3luoouslta2319twuk

Attachments

(1 file)

Popup shown to the user when they launch browser informing them of the Tracking Protection feature.

Please see Tracking Protection meta bug for specs.
No longer blocks: 1180674
Blocks: 1207731
Assignee: nobody → apastor
Note, this needs to work in both landscape and portrait. Eric is working on visuals for this presently.
blocking-b2g: --- → 2.5+
Whiteboard: [systemsfe]
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Let's UI review this in the meanwhile I add some tests. Eric, could you please take a look? Thanks!
Attachment #8669004 - Flags: ui-review?(epang)
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Looks good to me, thanks Alberto!

I'm guessing the link will be tappable when the site page is ready?

By the way I've added the landscape version to the spec: https://mozilla.box.com/s/qdb9m1dt365mlu3luoouslta2319twuk
Attachment #8669004 - Flags: ui-review?(epang) → ui-review+
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Adding Tiff to ui-review from a ixd perspective :)
Attachment #8669004 - Flags: ui-review?(tshakespeare)
Hey Alberto, Tif mentioned that there was a question about what happens when the user taps 'Learn More' link from the FTE TP PopUp. We're starting to understand the complexity of this 'seemingly simple' question. :)

• The PopUp should remain until the user taps 'Got it'.
• Tapping the 'Learn More' link opens a new Browser window (the SUMO Tracking Protection page, which is TBD). 
• The user can navigate the web from here (the sumo page), and open new Browser windows because this page will show a URL. 
• Navigating away from the sumo page, should present the FTE TP PopUp.
• If the user, doesn't tap 'Got it' and closes open browser windows/quits the Browser App, present the FTE TP PopUp the next time the Browser is launched.

Basically, can we make the sumo page URL an 'exception' to showing the PopUp but show it for all other pages?

Alberto, does this answer your question? We just want to make sure we're addressing the correct question. thanks! :)
Flags: needinfo?(apastor)
Thanks so much Alberto for helping me get the patch on my phone this AM! :)

Looking at the FTE PopUp, there are a few outstanding issues:

- If the popup happens to be in foreground when the phone goes to sleep, it remains overtop of the lockscreen (100% repro)
- The settings defaults to 'on' when it should default to "off". (I noticed the TP setting in Settings is in a different state, is that b/c they aren't connected yet?)
- "M" in learn more should be upper case.
- "P" in toggle tracking protection should be upper case.
- "." should be at the end of the supporting text under the toggle title. 
- "I" in it on button should be upper case. 
- It looks like the text within the control center graphic is "live"? That should also be title case.

Thanks!!
(In reply to katieC from comment #6)
> Hey Alberto, Tif mentioned that there was a question about what happens when
> the user taps 'Learn More' link from the FTE TP PopUp. We're starting to
> understand the complexity of this 'seemingly simple' question. :)
> 
> • The PopUp should remain until the user taps 'Got it'.
> • Tapping the 'Learn More' link opens a new Browser window (the SUMO
> Tracking Protection page, which is TBD). 
> • The user can navigate the web from here (the sumo page), and open new
> Browser windows because this page will show a URL. 
> • Navigating away from the sumo page, should present the FTE TP PopUp.
> • If the user, doesn't tap 'Got it' and closes open browser windows/quits
> the Browser App, present the FTE TP PopUp the next time the Browser is
> launched.
> 
> Basically, can we make the sumo page URL an 'exception' to showing the PopUp
> but show it for all other pages?
> 
> Alberto, does this answer your question? We just want to make sure we're
> addressing the correct question. thanks! :)


Thanks for the feedback, Katie. I'll implement that. Thanks!
Flags: needinfo?(apastor)
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

- Tif, all your comments should be fixed now. Could you please download the patch and try again?

- Katie, I implemented the behavior that you commented. Could you please review that everything looks good? Thanks!
Attachment #8669004 - Flags: feedback?(kcaldwell)
Hey Alberto - can you change where the Learn More link goes?

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1205040#c10

This is a temporary spot until the KB page for TP is created (Bug 1210155). I will update Bug 1211953 to include updating the popup as well as the Setting area.

Everything else looks good. I tried out the updates from Katie and I's feedback and that works well - thanks! :)
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Looks great! Thanks Alberto.
Attachment #8669004 - Flags: feedback?(kcaldwell) → feedback+
Attachment #8669004 - Flags: ui-review?(tshakespeare) → review?(mhenretty)
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

oops - looks like you removed my UI-review. I'll check out the updated patch this afternoon. Thanks!
Attachment #8669004 - Flags: ui-review?(tshakespeare)
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Looks good! Thanks Alberto!
Attachment #8669004 - Flags: ui-review?(tshakespeare) → ui-review+
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

I'm reviewing ui-reviews since last night the spec changed again. I'll upload a new image shortly.
Attachment #8669004 - Flags: ui-review+
Attachment #8669004 - Flags: feedback+
User Story: (updated)
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Looking fancy!

I added some review comments/questions/concerns. Re-flag me when they are address. 2 of them I won't block the review on, but I would *really* love to see TrackingNotice removed from the normal load path and only loaded by the browser if the setting is false. If it's too much work to do this now, let's file a followup for it.

Also, Eric made some changes to the visual spec.
Attachment #8669004 - Flags: review?(mhenretty)
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Eric, could you please take a look to the new implementation? Thanks!
Attachment #8669004 - Flags: ui-review?(epang)
Attachment #8669004 - Flags: review?(mhenretty)
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Left a couple of suggestions on github. Overall it's an r+, thanks!
Attachment #8669004 - Flags: review?(mhenretty) → review+
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Hey Alberto, this looks good visually, but I noticed a bug.
When you have the dialog open and you press the power button to lock your device when you press it again the pop up is on top of the lock screen.  Can you flag me again when it's fixed? Thanks for working on this!

Flagging Tif to take a look at it from a ixd perspective.
Attachment #8669004 - Flags: ui-review?(tshakespeare)
Attachment #8669004 - Flags: ui-review?(epang)
Attachment #8669004 - Flags: ui-review-
Priority: -- → P2
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Alberto did you fix it? Tried it again and it doesn't seem to be happening anymore.  R+
Attachment #8669004 - Flags: ui-review- → ui-review+
Yeah! Was waiting for the tests to flag you again. Thanks for checking!
Waiting for Tif's feedback before landing!
Flags: needinfo?(tshakespeare)
Comment on attachment 8669004 [details] [review]
[gaia] albertopq:1205042-browser-tracking > mozilla-b2g:master

Looks good! Thanks!
Flags: needinfo?(tshakespeare)
Attachment #8669004 - Flags: ui-review?(tshakespeare) → ui-review+
master: https://github.com/mozilla-b2g/gaia/commit/10f1ac0b8557a76ce54d36ca6235dda8a87e0058
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1215191
Depends on: 1215879
You need to log in before you can comment on or make changes to this bug.