1215482 - Support new bookmarks_store format in TV

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P1)

Description

[Michiel de Jong [:michielbdejong]]

In bug 1215086 I changed the format of bookmarks_store to be:

{
  id: "http://mozilla.org/",
  url: "http://mozilla.org/",
  name: "Mozilla",
  fxsyncRecords: {
    zMgfGkRinh92 : {
      "id": "zMgfGkRinh92",
      "type": "bookmark",
      "title": "Mozilla",
      "parentName": "mobile",
      "bmkUri": "http://mozilla.org/",
      "tags": [],
      "keyword": null,
      "description": null,
      "loadInSidebar": false,
      "parentid": "mobile"
    }
  }
}

This replaces the sync_bookmarks_store.

We need to update [1] to deal with this new format.

[1] https://github.com/weilonge/gaia/blob/4d1ff2b17850c3ec3d9c6869b73e9a45e4338db4/tv_apps/browser/js/datasync/sync_ds_helper.js#L82

Comment 1

[Michiel de Jong [:michielbdejong]]

Correction, the format will probably be:

{
  id: "http://mozilla.org/",
  url: "http://mozilla.org/",
  name: "Mozilla",
  fxsyncRecords: {
    zMgfGkRinh92 : {
      last_modified: 1444990424710,
      payload: {
        "id": "zMgfGkRinh92",
        "type": "bookmark",
        "title": "Mozilla",
        "parentName": "mobile",
        "bmkUri": "http://mozilla.org/",
        "tags": [],
        "keyword": null,
        "description": null,
        "loadInSidebar": false,
        "parentid": "mobile"
      }
    }
  }
}

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1215482-new-bookmarks_store-format > mozilla-b2g:master

Comment 3

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8674848 [details] [review]
[gaia] michielbdejong:1215482-new-bookmarks_store-format > mozilla-b2g:master

I haven't tested this code yet, but wanted to ask you for some early feedback on the diff.

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8674848 [details] [review]
[gaia] michielbdejong:1215482-new-bookmarks_store-format > mozilla-b2g:master

Hey Michiel, The overall idea is nice! We still need an iteration to update/add/remove records for IndexedDB based on the new bookmarks store. Thanks for this. :)

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/TVBrowser/master/Bug1215482 > mozilla-b2g:master

Comment 6

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8676002 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1215482 > mozilla-b2g:master

Hey Michiel,

Could you help to give the patch a feedback?
There are some duplicated changes with bug 1215086, and please ignore them.
The changes in this patch should be related to tv_apps only.
Thank you.

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8676002 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1215482 > mozilla-b2g:master

Hey Yifan,

Could you give the patch a feedback? Thank you~ :)

Comment 8

[yifan [:yifan][:yliao]]

Comment on attachment 8676002 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1215482 > mozilla-b2g:master

Thanks for the help! LGTM.

Comment 9

[Sean Lee [:seanlee][:weilonge]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/976a95d600ec40f839f2004896106f2da55351ce
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=623c20dbff06ec203ce8829970a6a520706863bc