Closed Bug 1215604 Opened 4 years ago Closed 4 years ago

Fennec firstrun SyncPanel does not launch web activity correctly

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

There are two parts to this ticket:

First, https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/firstrun/SyncPanel.java#32 launches the native Get Started activity directly.  This is probably a rebasing issue, since the world has moved on and we need to delegate (using the mechanism of Bug 1204937).  An example is at https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/firstrun/WelcomePanel.java#31.

Second, there's another mis-leading usage of the Get Started native activity, although it would only be shown to Sync 1.1 users: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/sync/setup/activities/SendTabActivity.java#258.

The over-arching issue is that we need to /remove/ the manifest entries for native activities when they aren't used, which would crash offending users like this one when the web flow is used.  This was intentionally a staged process; we'll pull the trigger in Bug 1192004.
Bug 1215604 - Use <intent-filter> indirection to allow native and web Sync Get Started activities. r?liuche
Attachment #8677143 - Flags: review?(liuche)
Comment on attachment 8677143 [details]
MozReview Request: Bug 1215604 - Use <intent-filter> indirection to allow native and web Sync Get Started activities. r?liuche

margaret: no reason to wait for liuche for this.  Steal if you can, please.
Attachment #8677143 - Flags: review?(margaret.leibovic)
Comment on attachment 8677143 [details]
MozReview Request: Bug 1215604 - Use <intent-filter> indirection to allow native and web Sync Get Started activities. r?liuche

https://reviewboard.mozilla.org/r/22895/#review20625
Attachment #8677143 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/integration/fx-team/rev/ebe762936d7aa9d7b3bdb586d6ff99b4196488d8
Bug 1215604 - Use <intent-filter> indirection to allow native and web Sync Get Started activities. r=margaret
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/ebe762936d7a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Attachment #8677143 - Flags: review?(liuche)
You need to log in before you can comment on or make changes to this bug.