1215617 - Add better graphical methods of filtering data in compare view

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

I just landed a patch in bug 1187000 to display e10s results by default in the compare view. This is better than the earlier situation, where people couldn't see such results at all, but we really should solve this properly by adding some kind of filtering interface to narrow down what is displayed.

My initial idea was a filtering interface like this: https://bug1187000.bmoattachments.org/attachment.cgi?id=8638154

We could also experiment with some kind of dialog box to filter the list of tests.

Lots of possibilities!

Comment 1

[William Lachance (:wlach)]

Attachment: Improved filtering UI PR

Example of new UI in action: http://wlach.github.io/treeherder/ui/perf.html#/compare?originalProject=mozilla-inbound&originalRevision=906f76d5adcf&newProject=mozilla-inbound&newRevision=3012b7a2c97c

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8677048 [details] [review]
Improved filtering UI PR

a few things to sort out.  specifically if we are doing this, we should expose the excludedPlatforms in the options.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8677048 [details] [review]
Improved filtering UI PR

Updated with an option to show excluded platforms.

Also fixed subtest view and added help tooltips for the various checkboxes.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I don't see where you added the checkbox- the code doesn't look that different from the first patch.

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8677048 [details] [review]
Improved filtering UI PR

Hmm, for some reason I made this PR from mozilla/treeherder, not wlach/treeherder. Anyway, updated it at that location, should be ready for review now.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8677048 [details] [review]
Improved filtering UI PR

thanks for making this!

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7f7f54f91cff381d2540cda2c5c67323016e932c
Bug 1215617 - Filtering interface for perfherder compare

Can now filter across test name and platform, as well as only
show significant changes and/or results for which we have confidence.

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/50172112e4ab8f3b77c81102b2a5aca7bbb5f018
Bug 1215617 - Fix minor markup problem

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/220529f04a35b2bcecc609afa54a4afccc0a7bd4
Bug 1215617 - Print a friendly message when compare view is empty

Including a hint to change the filters.

https://github.com/mozilla/treeherder/commit/92693f5be89930cc354e309b1baab2ce58ae156a
Bug 1215617 - Don't hide results we're not confident in by default

You should be able to see large changes at a glance when comparing
two revisions by default, even if we're not confident in them. That
way you'll know to retrigger them. :)