1215754 - [Metrics] AdvancedTelemetry airplane mode retry does not work properly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Metrics, defect)

Description

[Tamara Hills [:thills]]

This was found by Iris.

STR:

1.  AdvancedTelemetry Enabled.
2.  Turn on the airplane mode so that there is no network connectivity.
3.  Wait for the REPORT_INTERVAL to expire.
4.  RETRY_INTERVAL should be set.
5.  RETRY_INTERVAL expires.
6.  Turn off airplane mode

expected behavior: metrics should be sent after #6.
observed behavior: metrics not sent.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] tamarahills:bugfix/1215754-fix-advancedtelemetry-airplanemode-retry > mozilla-b2g:master

Comment 2

[Tamara Hills [:thills]]

Comment on attachment 8675207 [details] [review]
[gaia] tamarahills:bugfix/1215754-fix-advancedtelemetry-airplanemode-retry > mozilla-b2g:master

Hi Russ,

I fixed this by checking for navigator.online in one place instead of 3.  I checked for it at the actual transmit and then if it is offline, I just start the retry at that point.

The problem was that there were so many checks for navigator.online that it was skipping the handling to start the retryBatch.

Thanks,

-tamara

Comment 3

[Russ Nicoletti [:russn]]

Comment on attachment 8675207 [details] [review]
[gaia] tamarahills:bugfix/1215754-fix-advancedtelemetry-airplanemode-retry > mozilla-b2g:master

The changes look good. I have left a comment in the PR.

Comment 4

[Tamara Hills [:thills]]

Comment on attachment 8675207 [details] [review]
[gaia] tamarahills:bugfix/1215754-fix-advancedtelemetry-airplanemode-retry > mozilla-b2g:master

Hi Marshall,

This is to fix the retries when it's in airplane mode.  I had too many checks for navigator.onLine and it was short circuiting the code that makes it retry.

Thanks,

-tamara

Comment 5

[Marshall Culpepper [:marshall_law]]

Comment on attachment 8675207 [details] [review]
[gaia] tamarahills:bugfix/1215754-fix-advancedtelemetry-airplanemode-retry > mozilla-b2g:master

Looks good

Comment 6

[Tamara Hills [:thills]]

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=c784c86d01097cec45e13b825fad9cbe6b80e59f

Comment 7

[Iris Hsiao [:ihsiao]]

Verified@
Build ID               20151106013953
Gaia Revision          1fb7e4b7904d577a1859b91269a85b363ddc2836
Gaia Date              2015-11-06 02:30:49
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/f073181a927d63ae7abac86e47cc3872ccac7275
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151106.005858
Firmware Date          Fri Nov  6 00:59:06 UTC 2015
Bootloader             s1

Verify result:
Metrics can be sent after reconnected to network(wifi) from airplane mode.