121601 - After logout, user should be redirected to the index page

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P3)

Description

[Dave Miller [:justdave]]

We should consider having relogin.cgi redirect to the index page after telling
you you've been logged out and giving you sufficient time to read it.  Of
course, have a "click here" link in case your browser doesn't redirect.

I saw this on someone's locally modified Bugzilla and it works well.

Comment 1

[Joel Peshkin]

These unloved bugs have been sitting untouched since June 2002 or longer.  If
nobody does anything else to them, they certainly won't make 2.18
Retargetting to 2.20.  If you really plan to push them right now, you might pull
them back in.

Comment 2

[Frédéric Buclin]

Well, instead of pointing to relogin.cgi, we should move the code from relogin.cgi into index.cgi and get rid of relogin.cgi completely.

The information that the user has been logged out can be placed into a "message" (green box at the top of the page).

Comment 3

[Frédéric Buclin]

We are freezing the code for 3.0 in two weeks and we don't expect this bug to be fixed on time.

Comment 4

[Max Kanat-Alexander]

Because this will fix bug 478230, it is going into 3.4.

Comment 5

[Max Kanat-Alexander]

Attachment: v1

Okay, this was pretty simple.

We can't make the "logout" parameter accessible from every page because we don't have a global $vars. (I want to fix this problem some day by having a Bugzilla->message that just lets you push messages on to a stack...)

Comment 6

[Frédéric Buclin]

Comment on attachment 363069 [details] [diff] [review]
v1

Works nicely, r=LpSolit

Now if you access relogin.cgi directly, an error is thrown. We should probably redirect to index.cgi in this case, or have a better default so that it doesn't throw an error. Should be fixed in a separate bug. Max, could you file one?

Comment 7

[Max Kanat-Alexander]

Checking in index.cgi;
/cvsroot/mozilla/webtools/bugzilla/index.cgi,v  <--  index.cgi
new revision: 1.28; previous revision: 1.27
done
Checking in relogin.cgi;
/cvsroot/mozilla/webtools/bugzilla/relogin.cgi,v  <--  relogin.cgi
new revision: 1.42; previous revision: 1.41
done
Checking in Bugzilla/Auth/Persist/Cookie.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Persist/Cookie.pm,v  <--  Cookie.pm
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/sidebar.xul.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/sidebar.xul.tmpl,v  <--  sidebar.xul.tmpl
new revision: 1.27; previous revision: 1.26
done
Checking in template/en/default/global/common-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/common-links.html.tmpl,v  <--  common-links.html.tmpl
new revision: 1.20; previous revision: 1.19
done

Comment 8

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.4 in bug 494037.