Closed
Bug 1216068
Opened 9 years ago
Closed 9 years ago
(Gaia RTL 2.5) CSS refactoring: contacts animation
Categories
(Firefox OS Graveyard :: Gaia::Shared, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pelloux, Assigned: pelloux)
References
Details
Attachments
(1 file)
Rework Contacts animation to support RTL transitions.
These transition are in shared/ even if currently they seem to be only used Contacts app.
|
||
Comment 1•9 years ago
|
||
Attachment #8675569 -
Flags: review?(kevingrandon)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8675569 [details] [review]
[gaia] Phoxygen:bug1216068-bb-contacts-animations > mozilla-b2g:master
Looks fine to me, but because this is code specific to Contacts (although it sits in the shared/ folder), I think that Francisco or a contacts peer should probably review it. Thanks!
Attachment #8675569 -
Flags: review?(kevingrandon) → review?(francisco)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8675569 [details] [review]
[gaia] Phoxygen:bug1216068-bb-contacts-animations > mozilla-b2g:master
LGTM, tested on the phone and looking good.
Attachment #8675569 -
Flags: review?(francisco) → review+
|
|
||
Comment 4•9 years ago
|
||
Landed in master:
https://github.com/mozilla-b2g/gaia/commit/2548dc4d9cb70c6e9e9b0b2340c0162cfe172f6c
nga branch:
e4a22e0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•