1216183 - [Messages] We should not fail when the attachment is incorrect

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

I noticed that when we're in this situation like bug 1215471 we can't display the attachment menu. Here is the error log:

10-19 17:46:10.357 29418 29418 E Messages: [JavaScript Error: "TypeError: name.lastIndexOf is not a function" {file: "app://sms.gaiamobile.org/views/conversation/js/compose.js" line: 46}]


I think we should not crash like this and instead default to an empty name.

At the very least, replace line 682:

      var name = currentAttachment.name;


by

      var name = currentAttachment.name || '';

Comment 1

[Julien Wajsberg [:julienw]]

actually, "name" is not empty here. So the issue is that it's not a string.

I think we should change something in [1], make sure we get a string, and replace with '' if it's not a string.

[1] https://github.com/mozilla-b2g/gaia/blob/d344af789c6abadb754262af47827c2057b082db/apps/sms/views/conversation/js/attachment.js#L29

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] kumarrishav:Bug-1216183 > mozilla-b2g:master

Comment 3

[kumar rishav (:rishav_)]

Comment on attachment 8678218 [details] [review]
[gaia] kumarrishav:Bug-1216183 > mozilla-b2g:master

Here is the patch :) hope it's good.

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8678218 [details] [review]
[gaia] kumarrishav:Bug-1216183 > mozilla-b2g:master

I left comments on github :)

thanks !

Comment 5

[kumar rishav (:rishav_)]

Comment on attachment 8678218 [details] [review]
[gaia] kumarrishav:Bug-1216183 > mozilla-b2g:master

Hi Julien,
Hope it's fine now. Not sure if comments are fine or not.

Thanks

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8678218 [details] [review]
[gaia] kumarrishav:Bug-1216183 > mozilla-b2g:master

r=me but please fix the 2 nits before landing !

Thanks !

Comment 7

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/48d44fca6e37800faefed1b9f89db93852383765