12164 - Implement tri-state checkbox a and push buttons

Status: NEW

(Core :: XUL, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

I guess I didn't have a bug on this after all. Filing a new one for tracking.
This is per our discussion in email.

When you get the new value added, please reassign this back to me so that I can
adapt the checkbox code to use the CSS property, not an attribute.

Comment 1

[Peter Linss]

'tri-state' is now as legal value for the 'user-modify' property (CSS3
work-in-progress) (as is 'toggle' for regular radios & checkboxes)

Comment 2

[Mike Pinkerton (not reading bugmail)]

moving out past beta until someone tells me they're actually using tri-state
checkboxes.

Comment 3

[Hixie (not reading bugmail)]

I'm using a tristate check box! Oh, you mean in Mozilla. Sorry... :-)

Comment 4

[Paul MacQuiddy]

giving me rest of phillips open qa contact bugs, sorry for spam

Comment 5

[Paul MacQuiddy]

*IGNORE* - massive spam changing open XPToolkit bug's QA contact to
[e-mail]

Comment 6

[Peter Trudelle]

moving to m20, putting on helpwanted radar

Comment 7

[Peter Trudelle]

Mass move of all M20 bugs to M30.

Comment 8

[Peter Trudelle]

Mass moving M20 bugs to M30

Comment 9

[Peter Trudelle]

Mass-moving all M20-M30 XPToolkit bugs to Future

Comment 10

[John Morrison]

*** Bug 37287 has been marked as a duplicate of this bug. ***

Comment 11

[John Morrison]

Resummarizing to "Implement tri-state checkbox" since the CSS property is 
implemented. 

For any passersby, this would be a nice project, and could (should) be 
implemented entirely in XBL, likely by extending the existing binding for 
<checkbox>.

Comment 12

[Mike Pinkerton (not reading bugmail)]

well, i disagree with the summary change since the tri-state is implemented, it 
just uses an attribute instead of a css property to determine if it should be 
tri-state.

agreed that this should be xbl'ified though.

Comment 13

[John Morrison]

Duh. I meant to say 'Re-implement', since yes, the tri-state was in place.

Mike: Any pointers to the former code, or other pointers for someone who might
come along and have a look at this?

Comment 14

[Blake Ross]

yes, some pointers would be much appreciated if you have a second.

Comment 15

[John Morrison]

*** Bug 55572 has been marked as a duplicate of this bug. ***

Comment 16

[Mike Pinkerton (not reading bugmail)]

i think the old tri-state code is lumped into nsGFXCheckboxControlFrame.cpp.
Leaving as future since no one really seems to want this beast, and it can
probably be done fairly easily by anyone who does in XBL.

Comment 17

[Aaron Leventhal]

This needs to be done in XBL for accessibility purposes.See bug 58847. Widgets
should migrate to XBL.

Comment 18

[Mike Pinkerton (not reading bugmail)]

someone said xbl, so this goes to hyatt. ;)

Comment 19

[David Hyatt]

-> hewitt

Comment 20

[Peter Trudelle]

If nobody is using this, why is it needed for 1.0/MachV?

Comment 21

[basic]

I want to try and do the tri-state checkbox, what is the deal with "a and push
buttons" ? There seems to be already a tri-state checkbox type button.

Comment 22

[basic]

Attachment: patch (checkbox.xml -- implements tri-state and autoCheck)

I started based on the code found in button.xml for tri-state checkbox button
and autoCheck checkbox button and modified it to work with checkbox.xml

Comment 23

[basic]

Attachment: patch v2 (also fixes some issues with button.xml and adds threeState property)

this is a better patch. Fixes some issues with button.xml
1. autoCheck property returns false sometimes when it is true.
2. when in indetermined state a button doesn't always get checked when clicked.


added threeState property. When set to true, enables cycling between 3 states
unchecked/indetermined/checked when clicked.

Comment 24

[basic]

Attachment: testcase

Comment 25

[basic]

Attachment: testcase

Comment 26

[basic]

Attachment: testcase

Comment 27

[basic]

Attachment: testcase

Comment 28

[basic]

oops sorry about the spam

Comment 29

[basic]

Attachment: patch (v3)

this one has no threeState prop.
fixes button.xml's autoCheck returning false when attribute not set issue.

Comment 30

[basic]

Attachment: testcase for checkbox

Comment 31

[basic]

Attachment: patch (v4) uses getAttribute() =="true" rather than hasAttribute();

Comment 32

[basic]

Attachment: patch (v5)

made a mistake in patch (v4) that caused autoCheck to be always set to true
when set via property. The previous patch also had touch on some code that I
shouldn't have touched.

Comment 33

[David Hyatt]

We need style rules in the skins for handling the look of a tristate checkbox,
right?

Also, we should file breakout bugs for <button type="checkbox"> and <listitem
type="checkbox">, both of which support all of the same stuff.

Comment 34

[basic]

<button type="checkbox"> is mostly implemented (except for skinning and maybe
some bugs) Bug 119628
<listitem type="checkbox"> is not implemented yet (listitem has just been
implemented type="checkbox" has not) bug 119626

Comment 35

[basic]

Attachment: patch (checkbox.xml only)

seperating changes for button.xml to bug 119628

Comment 36

[Joe Hewitt (gone)]

I'm not going to have time to work on this myself, so I'll assign it to
[e-mail] since he is already working on it.  Thanks for helping out!

Comment 37

[basic]

If I'm not mistaken what is left here is the skinning of the tristate checkbox.
I've no idea who to send this to for skinning. Suggestions anyone?

Comment 38

[Joe Hewitt (gone)]

Moving non nsbeta1+ XUL 1.0 bugs to mozilla1.2

Comment 39

[basic]

assigning to nobody

Comment 40

[David G King]

Changing Target Milestone from 1.2a.....

Comment 41

[David G King]

Almost asked if this should be checked in without the skinning stuff, but then I
noticed that the patch is suffering from age.

Mind you, looking at Bug #119626 and Bug #119628, I'm not sure how important the
skinning issue is. If I update the patch to match the current state of the file,
how likely is it that it can go in without the skin update?

Comment 42

[alexander :surkov (:asurkov)]

I think it's needed to add tristate behaviour to checkbox. When I click on
checkbox then checkbox state is changed by the following way: not checked,
checked, indeterminate.

Comment 43

[alexander :surkov (:asurkov)]

About realization of tristate checkbox:
http://lists.w3.org/Archives/Public/www-dom/2002JanMar/0038.html