Implement tri-state checkbox a and push buttons

NEW
Unassigned

Status

()

defect
P3
normal
20 years ago
10 years ago

People

(Reporter: mikepinkerton, Unassigned)

Tracking

({css3, helpwanted})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [xul1.0-widgets-checkbox])

Attachments

(2 attachments, 9 obsolete attachments)

I guess I didn't have a bug on this after all. Filing a new one for tracking.
This is per our discussion in email.

When you get the new value added, please reassign this back to me so that I can
adapt the checkbox code to use the CSS property, not an attribute.

Updated

20 years ago
Assignee: peterl → pinkerton

Comment 1

20 years ago
'tri-state' is now as legal value for the 'user-modify' property (CSS3
work-in-progress) (as is 'toggle' for regular radios & checkboxes)
Status: NEW → ASSIGNED
Target Milestone: M15
moving out past beta until someone tells me they're actually using tri-state
checkboxes.
Whiteboard: 2 days
Summary: Make tri-state checkbox use a CSS property, not an attribute → {css3} Make tri-state checkbox use a CSS property, not an attribute
I'm using a tristate check box! Oh, you mean in Mozilla. Sorry... :-)

Comment 4

20 years ago
giving me rest of phillips open qa contact bugs, sorry for spam
Keywords: css3

Updated

20 years ago
Summary: {css3} Make tri-state checkbox use a CSS property, not an attribute → Make tri-state checkbox use a CSS property, not an attribute

Comment 5

20 years ago
*IGNORE* - massive spam changing open XPToolkit bug's QA contact to
jrgm@netscape.com
QA Contact: paulmac → jrgm
Target Milestone: M15 → M18

Comment 6

20 years ago
moving to m20, putting on helpwanted radar
Keywords: helpwanted
Target Milestone: M18 → M20

Comment 7

20 years ago
Mass move of all M20 bugs to M30.

Comment 8

20 years ago
Mass moving M20 bugs to M30
Target Milestone: M20 → M30

Comment 9

19 years ago
Mass-moving all M20-M30 XPToolkit bugs to Future
Target Milestone: M30 → Future

Comment 10

19 years ago
*** Bug 37287 has been marked as a duplicate of this bug. ***

Comment 11

19 years ago
Resummarizing to "Implement tri-state checkbox" since the CSS property is 
implemented. 

For any passersby, this would be a nice project, and could (should) be 
implemented entirely in XBL, likely by extending the existing binding for 
<checkbox>.
Summary: Make tri-state checkbox use a CSS property, not an attribute → Implement tri-state checkbox
Whiteboard: 2 days
well, i disagree with the summary change since the tri-state is implemented, it 
just uses an attribute instead of a css property to determine if it should be 
tri-state.

agreed that this should be xbl'ified though.

Comment 13

19 years ago
Duh. I meant to say 'Re-implement', since yes, the tri-state was in place.

Mike: Any pointers to the former code, or other pointers for someone who might
come along and have a look at this?

Comment 14

19 years ago
yes, some pointers would be much appreciated if you have a second.

Comment 15

19 years ago
*** Bug 55572 has been marked as a duplicate of this bug. ***
i think the old tri-state code is lumped into nsGFXCheckboxControlFrame.cpp.
Leaving as future since no one really seems to want this beast, and it can
probably be done fairly easily by anyone who does in XBL.

Comment 17

19 years ago
This needs to be done in XBL for accessibility purposes.See bug 58847. Widgets
should migrate to XBL.
someone said xbl, so this goes to hyatt. ;)
Assignee: pinkerton → hyatt
Status: ASSIGNED → NEW

Updated

18 years ago
Blocks: 70753
Status: NEW → ASSIGNED
Summary: Implement tri-state checkbox → Implement tri-state checkbox a and push buttons
Whiteboard: [xul1.0-widgets-checkbox]
Target Milestone: Future → mozilla0.9.6

Comment 19

18 years ago
-> hewitt
Assignee: hyatt → hewitt
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9.6 → mozilla0.9.7

Updated

18 years ago
Status: NEW → ASSIGNED

Updated

18 years ago
Target Milestone: mozilla0.9.7 → mozilla0.9.9

Comment 20

18 years ago
If nobody is using this, why is it needed for 1.0/MachV?

Comment 21

18 years ago
I want to try and do the tri-state checkbox, what is the deal with "a and push
buttons" ? There seems to be already a tri-state checkbox type button.

Comment 22

18 years ago
I started based on the code found in button.xml for tri-state checkbox button
and autoCheck checkbox button and modified it to work with checkbox.xml

Updated

18 years ago
Keywords: patch

Comment 23

18 years ago
this is a better patch. Fixes some issues with button.xml
1. autoCheck property returns false sometimes when it is true.
2. when in indetermined state a button doesn't always get checked when clicked.


added threeState property. When set to true, enables cycling between 3 states
unchecked/indetermined/checked when clicked.
Attachment #63465 - Attachment is obsolete: true

Updated

18 years ago
Keywords: mozilla0.9.8, review

Comment 24

18 years ago
Posted file testcase (obsolete) —

Comment 25

18 years ago
Posted file testcase (obsolete) —

Comment 26

18 years ago
Posted file testcase (obsolete) —

Comment 27

18 years ago
Posted file testcase (obsolete) —

Comment 28

18 years ago
oops sorry about the spam

Comment 29

18 years ago
Posted patch patch (v3) (obsolete) — Splinter Review
this one has no threeState prop.
fixes button.xml's autoCheck returning false when attribute not set issue.
Attachment #63734 - Attachment is obsolete: true

Comment 30

18 years ago
Attachment #63791 - Attachment is obsolete: true
Attachment #63792 - Attachment is obsolete: true
Attachment #63793 - Attachment is obsolete: true
Attachment #63794 - Attachment is obsolete: true

Comment 31

18 years ago
Attachment #63915 - Attachment is obsolete: true

Comment 32

18 years ago
Posted patch patch (v5) (obsolete) — Splinter Review
made a mistake in patch (v4) that caused autoCheck to be always set to true
when set via property. The previous patch also had touch on some code that I
shouldn't have touched.
Attachment #63963 - Attachment is obsolete: true

Comment 33

18 years ago
We need style rules in the skins for handling the look of a tristate checkbox,
right?

Also, we should file breakout bugs for <button type="checkbox"> and <listitem
type="checkbox">, both of which support all of the same stuff.

Comment 34

18 years ago
<button type="checkbox"> is mostly implemented (except for skinning and maybe
some bugs) Bug 119628
<listitem type="checkbox"> is not implemented yet (listitem has just been
implemented type="checkbox" has not) bug 119626

Comment 35

18 years ago
seperating changes for button.xml to bug 119628
Attachment #64046 - Attachment is obsolete: true

Comment 36

18 years ago
I'm not going to have time to work on this myself, so I'll assign it to
_basic@yahoo.com since he is already working on it.  Thanks for helping out!
Assignee: hewitt → _basic
Status: ASSIGNED → NEW

Updated

18 years ago
Keywords: mozilla1.0+

Comment 37

18 years ago
If I'm not mistaken what is left here is the skinning of the tristate checkbox.
I've no idea who to send this to for skinning. Suggestions anyone?

Comment 38

18 years ago
Moving non nsbeta1+ XUL 1.0 bugs to mozilla1.2
Target Milestone: mozilla0.9.9 → mozilla1.2

Updated

18 years ago
No longer blocks: 70753

Updated

18 years ago
Keywords: mozilla1.0+mozilla1.0

Comment 39

17 years ago
assigning to nobody
Assignee: basic → nobody

Comment 40

16 years ago
Changing Target Milestone from 1.2a.....
Target Milestone: mozilla1.2alpha → ---

Comment 41

16 years ago
Almost asked if this should be checked in without the skinning stuff, but then I
noticed that the patch is suffering from age.

Mind you, looking at Bug #119626 and Bug #119628, I'm not sure how important the
skinning issue is. If I update the patch to match the current state of the file,
how likely is it that it can go in without the skin update?

Updated

16 years ago
Keywords: mozilla0.9.8
I think it's needed to add tristate behaviour to checkbox. When I click on
checkbox then checkbox state is changed by the following way: not checked,
checked, indeterminate.
You need to log in before you can comment on or make changes to this bug.