1216407 - Use mozilla/Endian.h for NfcService

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb. 9]

In NfcService we did BigEndian->LittleEndian conversion in [1],
we should use mozilla/Endian.h to leverage this.

[1]: https://dxr.mozilla.org/mozilla-central/source/dom/nfc/gonk/NfcService.cpp#336

Comment 1

[Thomas Nguyen (:tnguyen)]

Attachment: Patch V1

Using Endian.h to read the first uint32_t value (data size)

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb. 9]

Comment on attachment 8700944 [details] [diff] [review]
Patch V1

Review of attachment 8700944 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/gonk/NfcService.cpp
@@ +334,5 @@
>  
>    while (aBuffer->GetSize()) {
>      const uint8_t* data = aBuffer->GetData();
> +    uint32_t parcelSize = BigEndian::readUint32(data);
> +

remove extra line

Comment 3

[Thomas Nguyen (:tnguyen)]

Try result :
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8b7c080e7dd&selectedJob=14888185

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/3c4555f38aad

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c4555f38aad