1216550 - Legacy profiler front isn't destroyed

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Alexandre Poirot [:ochameau]]

That ends up preventing opening a toolbox more than once against the same app/tab/target.
This typically ends up in a broken, zombie toolbox that you can't close in WebIDE.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8676261 [details] [diff] [review]
patch v1

Review of attachment 8676261 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this review from jryans, but looks good! Is this something that needs uplifted?

Comment 3

[Alexandre Poirot [:ochameau]]

Not a big deal as it's not a very common pattern (opening a toolbox more than once against the same app)
But that may prevent some broken toolbox in webide if this LegacyProfilerFront is already in aurora.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

"Nice to have" for Aurora I'd say. :)

Comment 5

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/230d6e3c6060b86fc5eed34b7a8303c2a4d0cf8d
Bug 1216550 - Destroy profiler front on toolbox destruction. r=jsantell

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/230d6e3c6060