Closed Bug 1216591 Opened 8 years ago Closed 8 years ago

Support IFNDEF on Gaia preprocessor

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file)

[gaia] ferjm:bug1216591.ifndef > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rickychien
: review+
fabrice
: feedback+
Details | Review 
      No description provided.
Assignee: nobody → ferjmoreno
Attachment #8676363 - Flags: review?(rchien)
Comment on attachment 8676363 [details] [review]
[gaia] ferjm:bug1216591.ifndef > mozilla-b2g:master

Fabrice, could you check that this is what you need, please?
Attachment #8676363 - Flags: feedback?(fabrice)
Attachment #8676363 - Flags: feedback?(fabrice) → feedback+
Comment on attachment 8676363 [details] [review]
[gaia] ferjm:bug1216591.ifndef > mozilla-b2g:master

I think it's great and I leaved a nit that I prefer to print all utils.log to lowercase.
Attachment #8676363 - Flags: review?(rchien) → review+
https://github.com/mozilla-b2g/gaia/commit/8aa0b41b5dd20755d9bc45fdb2ef43e25e0d0724
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 1218288
Blocks: fxos-sync
Priority: -- → P2
Target Milestone: --- → FxOS-S10 (30Oct)
Blocks: 1218288
No longer depends on: 1218288
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.