1216662 - Revert Geolocation switch in FF43

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Toby Elliott [:telliott]]

In consultation with Nick, Mark and Laura, we've decided for non-technical reasons to not push the switch to Mozilla Location Service in FF43 (Bug 1197211). Thus, we need to revert https://hg.mozilla.org/releases/mozilla-aurora/rev/6f724b1e2353

Unfortunately, Garvan is no longer with us, so we have no FF dev who can simply submit a changeset.

Comment 1

[Toby Elliott [:telliott]]

[Tracking Requested - why for this release]: This has been added and now needs to be reverted.

Comment 2

[:garvan]

Attachment: bug1216662.diff

Comment 3

[Toby Elliott [:telliott]]

Comment on attachment 8676400 [details] [diff] [review]
bug1216662.diff

<3 Garvan. We miss you!

Comment 4

[Hanno Schlichting]

Comment on attachment 8676400 [details] [diff] [review]
bug1216662.diff

Review of attachment 8676400 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx Garvan!!!!

Comment 5

[:garvan]

Bugs don't get easier than this one :), I'll land on central and request uplift to Aurora?

Comment 6

[Hanno Schlichting]

@Garvan: Yes, please. Or Toby can ask for checkin-needed and file the uplift request. Let's see who gets it done first :)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/509f6c9e655a

Comment 8

[:garvan]

Toby: I think no checkin-needed, as I landed it on central (well, inbound), but if you could take over the uplift request that would be great, I don't know who to file it to

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since we need to revert this for 43/44.

Comment 10

[Carsten Book [:Tomcat]]

clearing checkin-needed since i guess liz has other tools to track this :)

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/509f6c9e655a

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Where "tools" = "checking my bugzilla queries". 
We do need to uplift this to aurora too. Toby can you fill out the form? Sorry it's a bit of a hoop to jump through. But it helps us keep our process straight. Thanks!

Comment 13

[Toby Elliott [:telliott]]

Comment on attachment 8676400 [details] [diff] [review]
bug1216662.diff

Approval Request Comment
[User impact if declined]: Feature has been pulled from subsequent branches. No effect on Aurora (since it remains preffed on here), but needs to be backported for future releases.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8676400 [details] [diff] [review]
bug1216662.diff

Approved for uplift to aurora, turns off MLS in release builds.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eb791fa842b6