Closed Bug 1216662 Opened 4 years ago Closed 4 years ago

Revert Geolocation switch in FF43

Categories

(Core :: DOM: Geolocation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 + fixed
firefox44 + fixed

People

(Reporter: telliott, Assigned: garvan)

References

Details

Attachments

(1 file)

In consultation with Nick, Mark and Laura, we've decided for non-technical reasons to not push the switch to Mozilla Location Service in FF43 (Bug 1197211). Thus, we need to revert https://hg.mozilla.org/releases/mozilla-aurora/rev/6f724b1e2353

Unfortunately, Garvan is no longer with us, so we have no FF dev who can simply submit a changeset.
[Tracking Requested - why for this release]: This has been added and now needs to be reverted.
Attached patch bug1216662.diffSplinter Review
Attachment #8676400 - Flags: review?(hschlichting)
Comment on attachment 8676400 [details] [diff] [review]
bug1216662.diff

<3 Garvan. We miss you!
Comment on attachment 8676400 [details] [diff] [review]
bug1216662.diff

Review of attachment 8676400 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx Garvan!!!!
Attachment #8676400 - Flags: review?(hschlichting) → review+
Bugs don't get easier than this one :), I'll land on central and request uplift to Aurora?
@Garvan: Yes, please. Or Toby can ask for checkin-needed and file the uplift request. Let's see who gets it done first :)
Keywords: checkin-needed
Toby: I think no checkin-needed, as I landed it on central (well, inbound), but if you could take over the uplift request that would be great, I don't know who to file it to
Tracking since we need to revert this for 43/44.
clearing checkin-needed since i guess liz has other tools to track this :)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/509f6c9e655a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Where "tools" = "checking my bugzilla queries". 
We do need to uplift this to aurora too. Toby can you fill out the form? Sorry it's a bit of a hoop to jump through. But it helps us keep our process straight. Thanks!
Flags: needinfo?(telliott)
Attachment #8676400 - Flags: approval-mozilla-aurora?
Flags: needinfo?(telliott)
Attachment #8676400 - Flags: approval-mozilla-aurora?
Comment on attachment 8676400 [details] [diff] [review]
bug1216662.diff

Approval Request Comment
[User impact if declined]: Feature has been pulled from subsequent branches. No effect on Aurora (since it remains preffed on here), but needs to be backported for future releases.
Attachment #8676400 - Flags: approval-mozilla-aurora?
Comment on attachment 8676400 [details] [diff] [review]
bug1216662.diff

Approved for uplift to aurora, turns off MLS in release builds.
Attachment #8676400 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.