Add appropriate license notice for Tracking Protection blocklists

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
P3
blocker
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ellee, Assigned: mcav)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.5+)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

Tracking Protection blocklists from Disconnect are GPL'ed. We need to add an appropriate notice and license in our Open Source Notices section. We should caveat that it does NOT apply to any source code for Firefox OS, only to blocklist that is downloaded after installation.

See about:license#gpl-3.0 in Firefox Desktop (42+) for an example.
See Also: → bug 1210192
Blocks: 1180674
Legal release blocker
blocking-b2g: --- → 2.5+
Whiteboard: [systemsfe]
Priority: -- → P3
Elvin, whats the exact wording?
Flags: needinfo?(ellee)
Full GPL3 text can be found here: http://www.gnu.org/licenses/gpl-3.0.html

The full text must be included in the Open Source Notices page.

At the top section of the Open Source Notices page, after we list the source code licenses, we should add another paragraph:

"Additionally, this product uses blocklists for the Tracking Protection Feature provided by Disconnect, Inc. as separate and independent works under the GNU General Public License v3. This license applies only to the blocklists for this feature downloaded after installation, and does not apply to any of the source code for this product."

The GNU GPL v3 text should link as an anchor to the full text of the license that we are adding at the bottom of the page, like we do with the other licenses.
Flags: needinfo?(ellee)
Sorry, I made a typo in the above text. Corrected below. 

> "Additionally, this product uses blocklists provided by Disconnect, Inc. 
> for the Tracking Protection feature as separate and independent works under
> the GNU General Public License v3. This license applies only to the
> blocklists for this feature downloaded after installation, and does not
> apply to any of the source code for this product."
(Assignee)

Updated

3 years ago
Assignee: nobody → m
Created attachment 8677692 [details] [review]
[gaia] mcav:legal-gpl3 > mozilla-b2g:master
(Assignee)

Comment 6

3 years ago
Comment on attachment 8677692 [details] [review]
[gaia] mcav:legal-gpl3 > mozilla-b2g:master

Not sure who the proper reviewer is for this; Bugzilla suggests Evelyn.

This patch updates the text as described in Comment 3 and Comment 4. For some reason, GitHub refuses to display the HTML diff.
Attachment #8677692 - Flags: review?(ehung)

Comment 7

3 years ago
Comment on attachment 8677692 [details] [review]
[gaia] mcav:legal-gpl3 > mozilla-b2g:master

Thanks!
Attachment #8677692 - Flags: review?(ehung) → review+
Hi Marcus, if there is no source code that we need to provide GPLv3 notice for, can you please remove it from the bulleted list? (Just the link in the paragraph is sufficient.) Better to avoid confusion on that point. If we need it for new additions to the source code, then ignore this. :)
Flags: needinfo?(m)
(Assignee)

Comment 9

3 years ago
Comment on attachment 8677692 [details] [review]
[gaia] mcav:legal-gpl3 > mozilla-b2g:master

I've updated the patch to remove the gpl3 from the list of licenses. See anything else you'd like to change?
Flags: needinfo?(m)
Attachment #8677692 - Flags: feedback?(ellee)
Nothing else jumps out. Thanks!
(Assignee)

Comment 11

3 years ago
master: https://github.com/mozilla-b2g/gaia/commit/341d4225e4bf3d177393df9257e2f2bd06e3eba3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Attachment #8677692 - Flags: feedback?(ellee)
You need to log in before you can comment on or make changes to this bug.