1217064 - [mozilla-taskcluster] Enable decision tasks on pine

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Greg Arndt [:garndt]]

Decision task needs to run for pine.

Comment 1

[Pete Moore [:pmoore][:pete]]

For anyone who wants to take a stab at this:

The pine branch probably needs to be defined in https://hg.mozilla.org/mozilla-central/file/default/testing/taskcluster/tasks/branches (although I haven't tested if it will work without defining it - that should be checked).

A very basic job_flags.yml might do the trick, like this one: https://hg.mozilla.org/mozilla-central/file/daa7d98525e8/testing/taskcluster/tasks/branches/fx-team

It can be tested using the mach taskcluster-graph command.

See other decision tasks (e.g. from decision tasks that ran on another branch, e.g. go to treeherder, find a decision task, and look at what mach taskcluster-graph command ran) to understand what arguments it needs. Then you can run taskcluster-graph locally against a pine checkout, specifying appropriate arguments to the command. If this generates a correct task graph, you know you've set up the configuration correctly.

It might be that we need to explicitly enable the pine branch in https://github.com/taskcluster/mozilla-taskcluster - this is the component that listens for hg changes, and then submits decision tasks (i.e. tasks that run mach taskcluster-graph) to taskcluster. At the moment I'm not sure if mozilla-taskcluster processes changes to all hg gecko repos, or just a whitelist of them. If a whitelist only, we'd need to add pine to the list.

Comment 2

[Pete Moore [:pmoore][:pete]]

(In reply to Pete Moore [:pmoore][:pete] from comment #1)

> It might be that we need to explicitly enable the pine branch in
> https://github.com/taskcluster/mozilla-taskcluster - this is the component
> that listens for hg changes, and then submits decision tasks (i.e. tasks
> that run mach taskcluster-graph) to taskcluster. At the moment I'm not sure
> if mozilla-taskcluster processes changes to all hg gecko repos, or just a
> whitelist of them. If a whitelist only, we'd need to add pine to the list.

Looks like this might live here:
https://github.com/taskcluster/mozilla-taskcluster/blob/master/src/config/default.yml

Comment 3

[Alin Selagea [:aselagea]]

Attachment: url to pull request

Comment 4

[Alin Selagea [:aselagea]]

Attachment: updated PR url

Comment 5

[Pete Moore [:pmoore][:pete]]

I've pushed to staging and production - in a few moments it should be live.

Comment 6

[Pete Moore [:pmoore][:pete]]

All deployed, and seems to be working. From papertrail logs, I see things like:

GET https://hg.mozilla.org/projects/pine/json-pushes/ 

So looks like it should be working. Test will be to do a push to pine, and see if a decision task appears. If it doesn't, it could be either that something we did was wrong (unlikely) or it may be that we need to do something to enable treeherder integration with pine.

So if you do a push, let me know, and I can tail the logs to see if decision tasks get created, even if they don't show up on treeherder. If we are lucky, they will also show up on treeherder off the bat.

Comment 7

[Pete Moore [:pmoore][:pete]]

I was able to trigger a decision task:

https://treeherder.mozilla.org/#/jobs?repo=pine&revision=648502518580