Closed Bug 1217128 Opened 9 years ago Closed 8 years ago

crash in mozilla::layers::TextureClient::ForceRemove (shutdown)

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
43 Branch
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: milan, Assigned: nical)

References

Details

(Keywords: crash)

Crash Data

This bug was filed from the Socorro interface and is report bp-ce1b6d6d-1699-4976-99b3-82f362151019. ============================================================= Seems we didn't cover all the cases in bug 1195998, as there are crashes in version 44 (multiple platforms, see also https://crash-stats.mozilla.com/report/index/c7b1930f-7244-4890-9900-6bff72151020)
:nical, can you or Bas take a look at this, so that we're not left with the partial fix to ForceRemove crashes. Let's focus on the IPC related crashes.
Flags: needinfo?(nical.bugzilla)
Assignee: nobody → nical.bugzilla
Flags: needinfo?(nical.bugzilla)
This is clearly a case of the textures kept alive until too late in the shutdown. I spent some time looking into the media code and it looks like most of media is at least intended to shut down synchronously during when XPCOM_SHUTDOWN_OBSERVER_ID is fired which is what we need, so my current hunch is that maybe the plugin code doesn't get shut down in time. Digging...
Depends on: 1207220
No sign of this crash in 45 and 46 where bug 1207220 is fixed (44 uplift on the way). So marking as fixed, don't hesitate to reopen if it happens again on nightly or aurora.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Apparently, one of the signatures from bug 1243765 causing trouble in 44 release matches this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Bug 1261347 which just made it to mozilla-inbound should fix this.
Depends on: 1261347
It would appear that bug 1261347 never landed but the volume of this crash is extremely small now. Feb 1: ~205 crashes/day Mar 1: ~235 crashes/day Apr 1: ~ 31 crashes/day May 1: ~ 13 crashes/day Jun 1: ~ 14 crashes/day Jul 1: ~ 11 crashes/day Looking at recent crash reports it's all in Firefox 44 or earlier. I can't find any recent reports with a build we currently support. I don't know exactly what fixed this so I'm going to call this WORKSFORME. Feel free to reopen if there's evidence to suggest this is still an issue with current Firefox builds.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.