1217187 - Extend the manifest field/value detection support to allow detecting role:homescreen and similar

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Bug 900241 added the ability to detect some manifest fields and their support in a given b2g version, but for 2.5 we also need a way to detect the new role:"homescreen"

Comment 1

[Sam Foster [:sfoster] (he/him)]

[Blocking Requested - why for this release]: Required by the marketplace to avoid presenting homescreen apps to users on <2.5 devices, where replaceable homescreens are not supported.

Comment 2

[Andrew Overholt [:overholt]]

Can the version number be used as a key instead?

Comment 3

[Sam Foster [:sfoster] (he/him)]

(In reply to Andrew Overholt [:overholt] from comment #2)
> Can the version number be used as a key instead?

I think the Marketplace team is looking to avoid inferring specific feature support from a version number. But I'll let :ddurst respond as he is on the receiving end of this

Comment 4

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Expose replaceable homescreen feature

Comment 5

[(no longer active)]

Comment on attachment 8677590 [details] [diff] [review]
Expose replaceable homescreen feature

Review of attachment 8677590 [details] [diff] [review]:
-----------------------------------------------------------------

This one also needs a test.

Comment 6

[David Durst [:ddurst]]

(In reply to Sam Foster [:sfoster] from comment #3)
> (In reply to Andrew Overholt [:overholt] from comment #2)
> > Can the version number be used as a key instead?
> 
> I think the Marketplace team is looking to avoid inferring specific feature
> support from a version number. But I'll let :ddurst respond as he is on the
> receiving end of this

Indeed we are looking to avoid inferring specific feature support from a version number, but also looking to the manifest role because that is the (only) indicator that differentiates a homescreen "app" from a regular webapp -- iow, it's a required manifest value for the homescreen content type.

Comment 7

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Add feature detection for replaceable homescreen and unit test

Comment 9

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3acb49afffb7

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3acb49afffb7

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

mars, ddurst and I ended up chatting.  In order to test this, launch the dev version of the marketplace, and search :debug

The flag for detections are down below.

Comment 12

[David Durst [:ddurst]]

All the hasFeature() checks are there: addonsEnabled, homescreensEnabled, and lateCustomizationEnabled. If the checks return True, they'll be true.