1217463 - Deal with case where 'places' bookmark is missing.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P1)

Description

[Michiel de Jong [:michielbdejong]]

The test account sync2dot5@mailinator has no bookmarks folder with id 'places' (even though the parentId of the 'unfiled' folder is set to 'places').

Comment 1

[Michiel de Jong [:michielbdejong]]

It seems this happens when you create a new account, but don't go into the Bookmarks manager to create any folders.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/ferjm/gaia/commit/1fa877f130100aee48d3823c7d3cb521a876343a#diff-ed4ae19263bf74556f7542b37c38dbefR64

I think that line needs to be SyncBrowserDB.getBookmark({ parentid: 'places' }, bookmark => {...});

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Here is the sample code to fix the case:
SyncBrowserDB.getBookmark({ parentid: 'places' }, bookmark => {
  // make sure if firefox synced data saved in indexdDB
  if(bookmark) {
    this.cache.push({
      id: 'places',
      // XXX we need UX's suggestion to have a folder name for root folder
      //     and don't forget to handle l10n case.
      title: 'Synced Bookmarks',
      type: 'folder',
      readOnly: true
    });
  }

  // get bookmark data from origin indexdDB
  BrowserDB.getBookmarks(bookmarks => {
    this.cache = this.cache.concat(bookmarks);
    resolve();
  });
});

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Hey Dan, Could you give your comments here for this case? Thank you.

Comment 5

[Dan Huang[:danhuang]]

Fernando and Sean's sample code looks good to me. I will fix this.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1217463_deal_places_not_exist > mozilla-b2g:master

Comment 7

[Dan Huang[:danhuang]]

Comment on attachment 8678730 [details] [review]
[gaia] danhuang1202:1217463_deal_places_not_exist > mozilla-b2g:master

Please help me to review. This patch update the way to check if the synced bookmark data is saved in indexedDB. Thanks.

Comment 8

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8678730 [details] [review]
[gaia] danhuang1202:1217463_deal_places_not_exist > mozilla-b2g:master

LGTM. Thanks :)

Comment 9

[Sean Lee [:seanlee][:weilonge]]

Dan, please see my comments and fix them. Thank you!

Comment 10

[Dan Huang[:danhuang]]

Thank for the review.
merge in master:
https://github.com/mozilla-b2g/gaia/commit/f847caf6826baca3d31543c9e2593abfff0d8b70