121750 - Where should focus go when coming out of quick search

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Navin Gupta]

Regarding focus we have couple of issues, where should focus go when
coming out of quick search
 
-   message is selected in search view.
-   message is not selected in search view

jglick, any suggestions ?

Comment 1

[jglick]

>Regarding focus we have couple of issues, where should focus go when
>coming out of quick search
 
> - 1. message is selected in search view.

Message selected and then user clears search field. Would be good if message 
selected, remains selected. Similar to when to select a message and then change 
the sort, or turn on threading, the selected message remains selected.

That seem correct?

> - 2. message is not selected in search view
No message selected in search view. No message selected when when search 
cleared.

3. Message has secondary focus in search view (lighter highlight color) --> 
message retains secondary focus when search cleared.

Comment 2

[Jesse Ruderman]

Message selected in search view: clearing quicksearch leaves the message
selected. WFM.

No message selected in search view: bug 121359, "When exiting quick search, if
no message selected, scroll to first new message".

Comment 3

[jglick]

To summarize the issues:

A. Where should focus go when coming out of quick search. User does a QS and 
uses "Clear" button to exist QS. When the "Clear" button is activated, focus 
should remain where it was before the action.

1. If focus was in the QS text field, and user clicks Clear, focus remains in QS 
text field.
2. If focus was in the Thread Pane when user clicks Clear, focus remains in 
Thread Pane.
3. If focus was in Message Pane, focus remains in Msg Pane.
 

B. User backspaces or selects and deletes text in QS field to clear search. 
Focus remains in QS text field.

C. User clicks a folder in folder pane. Focus to folder pane.

D. User does a QS and exists via A or B. Selection of msg works as follows:

1. Message selected and then user clears search field. Message selected, remains 
selected. (Primary focus if  "A", secondary focus if "B".)

2. Message is not selected and then user clears search field. No message 
selected when when search cleared. Bug 121359, "When exiting quick search, if no 
message selected, scroll to first new message". (So no msg selected, but scrolls 
so first new msg visible).

That seem correct?

Comment 4

[timeless]

Z. user decides to be difficult: <tab>s to the clear button and presses <space>
Current result (for sent folder)
focus is lost and a while later you get this dialog:

<title>Advance to next unread message in Inbox?
<img alt="? bubble">Advance to next unread message in Inbox?
<input type=submit value="OK"><input type=submit value="Cancel">

Don't ask me which inbox it's going to visit, I have two [Inbox (120), Inbox
(134)] both have unread messages.

For fun, the user decides to be difficult and select cancel. Focus is still lost
but can be found somewhere between the sidebar and quicksearch. At this point,
entering something in QS and then tab+space results in a broken clear button.

I'm using an old version of mozilla, but I can't imagine we changed our behavior:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20020929

There's a general problem here, windows does solve it
steps:
1. get properties for a folder
1' observe the currently selected item
1~ for me it's [ ] readonly.
2. toggle it.
3. tab to apply
4. press space
*. I have to confirm because w2k isn't sure if i want to apply this setting to
the folder or to the folder and its children, w98 probably doesn't have this step.
5. focus is now at [x] readonly

It appears that intial focus is the thread pane, so that's the answer w2k would
suggest.

Comment 5

[Navin Gupta]

Attachment: proposed fix

Made it so that focus behave just as how jglick described in comment #3

Comment 6

[Navin Gupta]

cc cavin for review. 

Comment 7

[Cavin Song]

Comment on attachment 101448 [details] [diff] [review]
proposed fix

r=cavin.

Comment 8

[Scott MacGregor]

Comment on attachment 101448 [details] [diff] [review]
proposed fix

sr=mscott

Comment 9

[Navin Gupta]

fix checked in.

Comment 10

[laurel]

Marking verified.
OK using nov24 trunk: linux rh8, win98, mac OS 10.2.
Works according to comment #3 except for: if focus was in message pane, clearing
QS will not return focus to message pane.  Appears to be no true focus --
appears to be in thread pane, although no arrows work, etc.  Will spin off
anoter bug.