121359 - When exiting quick search, if no message selected, scroll to first new message

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[scottputterman]

1.  Do a quick search and have no messages selected
2.  Send yourself new mail and make sure biff goes off.
3.  Exit quick search.

Currently when you do this, the the thread pane is positioned at the top of the
folder.  But, in this scenario, the reason I have exited Quick Search is to read
my new mail. I think it should scroll to the first new message in this case,
just like we do when loading a folder.  If a message is selected in Quick
Search, it should still scroll to that message when exiting Quick Search.

Comment 1

[jglick]

I agree.

Comment 2

[Navin Gupta]

Attachment: proposed fix

The fix is to scroll to the first new message if preservedSelection array is of
size 0.

Comment 3

[Navin Gupta]

Cavin, David. Can I get reviews? thx. 

Comment 4

[Cavin Song]

Comment on attachment 93357 [details] [diff] [review]
proposed fix

r=cavin.

Comment 5

[David :Bienvenu]

Comment on attachment 93357 [details] [diff] [review]
proposed fix

sr=bienvenu, if you move the check for mTree into one of the other conditionals
(e.g., if (mTree && preservedSelection.GetSize() == 0), or if (mTree &&
resultKey != nsMsgKey_none)

Comment 6

[Navin Gupta]

fixed

Comment 7

[Navin Gupta]

fixed

Comment 8

[laurel]

OK using nov24 commercial trunk: linux rh8, win98.
Haven't been able to get this to work right on Mac.  Will try some more and spin
a new bug if can't get it to work.