1217536 - allow inbound_proxy supports '*'

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

update inbound_proxy to support '*' (always honour the x-forward-for header).

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1217536_1.patch

For the AWS proxy stuff. 
I used http://docs.aws.amazon.com/ElasticLoadBalancing/latest/DeveloperGuide/x-forwarded-headers.html for reference.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8678361 [details] [diff] [review]
1217536_1.patch

Review of attachment 8678361 [details] [diff] [review]:
-----------------------------------------------------------------

1. Rename t/remote_ip.t to t/013remote_ip.t
2. Add test case for an ipv6 style proxy and remote ip.
3. Update inbound_proxies description in template/en/default/admin/params/advanced.html.tmpl to account for '*'.

Fix on commit. r=dkl

::: Bugzilla/Util.pm
@@ +316,5 @@
> +    return $remote_ip if none { $_ eq $remote_ip } @proxies;
> +
> +    foreach my $ip (reverse @x_forwarded_for) {
> +        if (none { $_ eq $ip } @proxies) {
> +            # Kep the original IP address if the remote IP is invalid.

s/Kep/Keep/

Comment 3

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   f521f52..175f9c1  master -> master