1217602 - remove nsIPKIParamBlock

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Dana Keeler (she/her) [:keeler]]

nsIPKIParamBlock is unnecessary.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: MozReview Request: bug 1217602 - remove nsIPKIParamBlock

bug 1217602 - remove nsIPKIParamBlock

nsIPKIParamBlock was unnecessary.

Comment 2

[:Cykesiopka]

Comment on attachment 8677711 [details]
MozReview Request: bug 1217602 - remove nsIPKIParamBlock

https://reviewboard.mozilla.org/r/23003/#review20671

Wow, unnecessary indeed.

::: security/manager/pki/nsNSSDialogHelper.cpp:12
(Diff revision 1)
> -#include "nsIInterfaceRequestorUtils.h"
> +#include "nsNSSDialogHelper.h"

Nit: If I'm reading https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#CC_practices right, this should stay where it is, but separated into its own block.

::: security/manager/pki/nsNSSDialogs.cpp:403
(Diff revision 1)
> +  }

Nit: A blank line after this probably helps readability.

Comment 3

[Dana Keeler (she/her) [:keeler]]

https://reviewboard.mozilla.org/r/23003/#review20671

Thanks for the review!

> Nit: If I'm reading https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#CC_practices right, this should stay where it is, but separated into its own block.

Yep - good catch.

> Nit: A blank line after this probably helps readability.

Good call.

Comment 4

[Dana Keeler (she/her) [:keeler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=630feaf1e9bc

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23f0dcfdcce1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23f0dcfdcce1