1217653 - Intermittent test_fragment_noplay.html | application crashed [@ mozilla::DataEnded::Run()]

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=16117424&repo=mozilla-inbound

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=83cf25273093

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1217653 - MediaDecoder::GetOwner() should return null after shutdown. r=kinetik.

Bug 1217653 - MediaDecoder::GetOwner() should return null after shutdown. r=kinetik.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

stack:
 13:00:50     INFO -  Thread 0 (crashed)
 72339 
 13:00:50     INFO -   0  XUL!mozilla::DataEnded::Run() [MediaResource.cpp:78d977bb4596 : 915 + 0x3]
 72340 
 13:00:50     INFO -      rax = 0x5a5a5a5a5a5a5a5a   rdx = 0x00000000002b8d52
 72341 
 13:00:50     INFO -      rcx = 0x431bde82d7b634db   rbx = 0x00000001004c4ff0
 72342 
 13:00:50     INFO -      rsi = 0x0000000000000000   rdi = 0x000000012158aaa0
 72343 
 13:00:50     INFO -      rbp = 0x00007fff5fbfcbd0   rsp = 0x00007fff5fbfcbc0
 72344 
 13:00:50     INFO -       r8 = 0x00000000000a3929    r9 = 0x0000000040fda04b
 72345 
 13:00:50     INFO -      r10 = 0x00007fff82f88002   r11 = 0x00007fff82f9e1fc
 72346 
 13:00:50     INFO -      r12 = 0x0000000100497600   r13 = 0x0000000000000000
 72347 
 13:00:50     INFO -      r14 = 0x0000000100497620   r15 = 0x0000000100497690

https://hg.mozilla.org/mozilla-central/file/daa7d98525e8/dom/media/MediaResource.cpp#l915
The return value of MediaDecoder::GetOwner() is invalid after MediaDecoder is shut down.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Btw, this is a regression from bug 1215023.

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8677912 [details]
MozReview Request: Bug 1217653 - MediaDecoder::GetOwner() should return null after shutdown. r=kinetik.

https://reviewboard.mozilla.org/r/23049/#review20935

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80bcd16f00ab

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/80bcd16f00ab

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/80bcd16f00ab

Comment 10

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion