Closed Bug 1217661 Opened 4 years ago Closed 4 years ago

SeaMonkey build error: can't locate include file `PHeapSnapshotTempFileHelper.ipdl'

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set

Tracking

(firefox44 affected)

RESOLVED WORKSFORME
Tracking Status
firefox44 --- affected

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1217660 +++

1:05.01 c:\tb\5-central\src\mozilla\dom\ipc\PContent.ipdl:24: error: can't locate include file `PHeapSnapshotTempFileHelper.ipdl'

Probably from bug 1201597 and bug 912121
Apparently we need to also build devtools, and this is accomplished (afaik)
by adding MOZ_DEVTOOLS=all to confvars.sh.
(In reply to Edmund Wong (:ewong) from comment #1)
> Apparently we need to also build devtools, and this is accomplished (afaik)
> by adding MOZ_DEVTOOLS=all to confvars.sh.

tried that.  Not the right solution.. at least.. not the full solution.
(In reply to Edmund Wong (:ewong) from comment #0)
> Probably from bug 1201597 and bug 912121

Those both landed a month ago, but we were not broken until today, right?
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #3)
> (In reply to Edmund Wong (:ewong) from comment #0)
> > Probably from bug 1201597 and bug 912121
> 
> Those both landed a month ago, but we were not broken until today, right?

Right..  As mentioned on irc, it's a bustage from https://hg.mozilla.org/mozilla-central/rev/3f174efd3a89.
Blocks: 1203159
This makes my build succeed, not sure yet if we also need a package-manifest change in addition, though, I really should get to bed for today.

diff --git a/suite/app.mozbuild b/suite/app.mozbuild
--- a/suite/app.mozbuild
+++ b/suite/app.mozbuild
@@ -20,9 +20,10 @@ if CONFIG['MOZ_CALENDAR']:
     DIRS += [
         '/calendar/lightning',
         '/calendar/timezones'
     ]
 
 DIRS += [
     '/xpfe/components/autocomplete',
     '/suite',
+    '/devtools',
 ]
Attached patch proposed patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8677847 - Flags: review?(bugspam.Callek)
Fwiw, this patch both builds and passes |make package|
This situation might be resolved in bug 1217687 generally for all apps.
Attachment #8677847 - Attachment is obsolete: true
Attachment #8677847 - Flags: review?(bugspam.Callek)
Attachment #8677944 - Flags: review?(bugspam.Callek)
Comment on attachment 8677944 [details] [diff] [review]
proposed patch (v2)

got rs+ bustagefix from NeilAway over IRC
Comment on attachment 8677944 [details] [diff] [review]
proposed patch (v2)

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/15fa117f0444
I have pushed a more general fix in bug 1217687 which resumes adding /devtools through toolkit.  Once it lands, you'll likely need to revert the portion that added DIRS += [ '/devtools' ] in this bug to avoid a double including the directory (which I believe gives an error).

Sorry for all the trouble!
Attachment #8677944 - Flags: review?(bugspam.Callek) → review+
Ah I already have a patch in Bug 1208112
Backed out as bug 1217687 fixed it in a generic way.

https://hg.mozilla.org/comm-central/rev/9eb1045b4f35
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.