1217955 - Submit Firefox media test pf-jenkins results to Treeherder's API using Hawk credentials

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

As discussed on #treeherder, since pf-jenkins jobs will move to mozmill-ci some time in Q4, we will use the 'mozauto' client id requested by Henrik in bug 1215566.

Comment 1

[Ed Morley [:emorley]]

Thank you for filing this.

Looking at https://github.com/sydvicious/mozplatformqa-jenkins , I see it's using treeherder-client 1.6.0.

This will need updating to treeherder-client==1.8.0 which also then means `add_build_url()` is deprecated, so these calls will need removing:
https://github.com/sydvicious/mozplatformqa-jenkins/blob/fee0a753b051732e03b7ea5ef78ff0e9b8ffc1b9/treeherding.py#L437
https://github.com/sydvicious/mozplatformqa-jenkins/blob/fee0a753b051732e03b7ea5ef78ff0e9b8ffc1b9/treeherding.py#L502
https://github.com/sydvicious/mozplatformqa-jenkins/blob/fee0a753b051732e03b7ea5ef78ff0e9b8ffc1b9/treeherding.py#L586

The TreeherderAuth class no longer exists, so references to that need to be removed:
https://github.com/sydvicious/mozplatformqa-jenkins/blob/fee0a753b051732e03b7ea5ef78ff0e9b8ffc1b9/treeherding.py#L306-L311
...and instead the client_id and secret (which are the same for all repositories) passed to TreeherderClient like so:
http://treeherder.readthedocs.org/submitting_data.html#authentication

Hope that helps :-)

Comment 2

[Ed Morley [:emorley]]

Attachment: Submit results to Treeherder's API using Hawk credentials

Before this merges, the credentials file will need to have top-level "client_id" and "secret" keys added. Once this is in production, the old per-repo credentials can then be removed from the credentials file.

I'm presuming client_id will be 'mozauto' - myself or Henrik can provide the secret (note it's different for stage/prod).

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8681269 [details] [review]
Submit results to Treeherder's API using Hawk credentials

Thanks, Ed. :) The treeherder pieces in the mozplatformqa-jenkins repo take care of submission for WebRTC tests, so your PR actually addresses Bug 1217584. Want to attach it there instead? Syd or I can still do the review.

As for media-tests, Syd will take care of the updates needed in https://github.com/mjzffr/firefox-media-tests/tree/pf-jenkins

Comment 4

[Ed Morley [:emorley]]

Ah didn't realise - thank you for the clarification :-)

Comment 5

[Syd Polk :sydpolk]

Attachment: Use new treeherder Hawk credentials when submitting

Maja, please don't merge this until we can coordinate with updating credentials on pf-jenkins builders.

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8684453 [details] [review]
Use new treeherder Hawk credentials when submitting

r+wc - Please remove all references related to "build_url" in run_media_tests.py, treeherding.py, etc.

Comment 7

[Syd Polk :sydpolk]

Removed other calls to add_build_url, rebased, and force-pushed.

Comment 8

[Syd Polk :sydpolk]

All of the credentials for the test machines for media tests have been updated. Maja, please merge. Thanks.

Comment 9

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Merged
https://github.com/mjzffr/firefox-media-tests/commit/a9832edf67d8cc761746d61d25317055de7d6fec