Closed
Bug 1217964
Opened 9 years ago
Closed 9 years ago
Improve error messages on SSH failure
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gps, Assigned: gps)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
I've seen a few people get tripped up by the SSH errors on hg.mozilla.org recently. We should write the messages to be more actionable.
Assignee | ||
Comment 1•9 years ago
|
||
testing: ability to create LDAP accounts without hgAccount object class; r?smacleod Not all LDAP accounts have the "hgAccount" object class. We don't have test coverage for this scenario. In preparation for that, make addition of the hgAccount object class optional. Test output changed because LDAP preserves order, apparently.
Attachment #8678307 -
Flags: review?(smacleod)
Assignee | ||
Comment 2•9 years ago
|
||
hgserver: print helpful message when no HG account is configured (bug 1217964); r?smacleod This is infinitely better than before.
Attachment #8678308 -
Flags: review?(smacleod)
Assignee | ||
Comment 3•9 years ago
|
||
hgserver: print more helpful message when no or unknown command is attempted (bug 1217964); r?smacleod The old error message wasn't very helpful and was confusing.
Attachment #8678309 -
Flags: review?(smacleod)
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/23171/#review20645 ::: hgserver/pash/hg_helper.py:44 (Diff revision 1) > +The SSH command you specified is not allowed on this server. nit -- it's not really an "ssh" command -- it's a command to the "pash shell" or "ssh payload command" or some such. I don't have a better wording, but an explanatory comment here might be helpful to folks downstream.
Comment 5•9 years ago
|
||
Comment on attachment 8678307 [details] MozReview Request: testing: ability to create LDAP accounts without hgAccount object class; r?smacleod https://reviewboard.mozilla.org/r/23173/#review20649 lgtm - the "issue" is just a comment suggestion, not blocking
Attachment #8678307 -
Flags: review+
Updated•9 years ago
|
Attachment #8678308 -
Flags: review+
Comment 6•9 years ago
|
||
Comment on attachment 8678308 [details] MozReview Request: hgserver: print helpful message when no HG account is configured (bug 1217964); r?smacleod https://reviewboard.mozilla.org/r/23175/#review20651 lgtm
Comment 7•9 years ago
|
||
Comment on attachment 8678309 [details] MozReview Request: hgserver: print more helpful message when no or unknown command is attempted (bug 1217964); r?smacleod https://reviewboard.mozilla.org/r/23177/#review20653 lgtm
Attachment #8678309 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8678307 -
Flags: review?(smacleod)
Assignee | ||
Updated•9 years ago
|
Attachment #8678308 -
Flags: review?(smacleod)
Assignee | ||
Updated•9 years ago
|
Attachment #8678309 -
Flags: review?(smacleod)
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/f19958cd8fdc4c036d1e40578d4d847dfa91f8cc hgserver: print helpful message when no HG account is configured (bug 1217964); r=hwine https://hg.mozilla.org/hgcustom/version-control-tools/rev/9f4e6a2eafa1a1ea5ddbc3a6bbc99de662b1e31e hgserver: print better message when no or unknown command is attempted (bug 1217964); r=hwine
Assignee | ||
Comment 9•9 years ago
|
||
Deploying now. Thank you for the quick review. Hopefully fewer people get confused by the state of their accounts now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•