Last Comment Bug 1217964 - Improve error messages on SSH failure
: Improve error messages on SSH failure
Status: RESOLVED FIXED
:
Product: Developer Services
Classification: Other
Component: Mercurial: hg.mozilla.org (show other bugs)
: unspecified
: Unspecified Unspecified
-- normal
: ---
Assigned To: Gregory Szorc [:gps] (away until 2017-03-20)
: Hal Wine [:hwine] (use NI)
:
Mentors:
: 1116796 (view as bug list)
Depends on:
Blocks: 1218037
  Show dependency treegraph
 
Reported: 2015-10-23 12:20 PDT by Gregory Szorc [:gps] (away until 2017-03-20)
Modified: 2015-11-04 12:32 PST (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

MozReview Requests
Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:
Show discarded requests

Attachments
MozReview Request: testing: ability to create LDAP accounts without hgAccount object class; r?smacleod (40 bytes, text/x-review-board-request)
2015-10-23 13:14 PDT, Gregory Szorc [:gps] (away until 2017-03-20)
hwine: review+
Details | Review
MozReview Request: hgserver: print helpful message when no HG account is configured (bug 1217964); r?smacleod (40 bytes, text/x-review-board-request)
2015-10-23 13:14 PDT, Gregory Szorc [:gps] (away until 2017-03-20)
hwine: review+
Details | Review
MozReview Request: hgserver: print more helpful message when no or unknown command is attempted (bug 1217964); r?smacleod (40 bytes, text/x-review-board-request)
2015-10-23 13:14 PDT, Gregory Szorc [:gps] (away until 2017-03-20)
hwine: review+
Details | Review

Description User image Gregory Szorc [:gps] (away until 2017-03-20) 2015-10-23 12:20:50 PDT
I've seen a few people get tripped up by the SSH errors on hg.mozilla.org recently. We should write the messages to be more actionable.
Comment 1 User image Gregory Szorc [:gps] (away until 2017-03-20) 2015-10-23 13:14:41 PDT
Created attachment 8678307 [details]
MozReview Request: testing: ability to create LDAP accounts without hgAccount object class; r?smacleod

testing: ability to create LDAP accounts without hgAccount object class; r?smacleod

Not all LDAP accounts have the "hgAccount" object class. We don't have
test coverage for this scenario. In preparation for that, make addition
of the hgAccount object class optional.

Test output changed because LDAP preserves order, apparently.
Comment 2 User image Gregory Szorc [:gps] (away until 2017-03-20) 2015-10-23 13:14:43 PDT
Created attachment 8678308 [details]
MozReview Request: hgserver: print helpful message when no HG account is configured (bug 1217964); r?smacleod

hgserver: print helpful message when no HG account is configured (bug 1217964); r?smacleod

This is infinitely better than before.
Comment 3 User image Gregory Szorc [:gps] (away until 2017-03-20) 2015-10-23 13:14:45 PDT
Created attachment 8678309 [details]
MozReview Request: hgserver: print more helpful message when no or unknown command is attempted (bug 1217964); r?smacleod

hgserver: print more helpful message when no or unknown command is attempted (bug 1217964); r?smacleod

The old error message wasn't very helpful and was confusing.
Comment 4 User image Hal Wine [:hwine] (use NI) 2015-10-23 13:50:29 PDT
https://reviewboard.mozilla.org/r/23171/#review20645

::: hgserver/pash/hg_helper.py:44
(Diff revision 1)
> +The SSH command you specified is not allowed on this server.

nit -- it's not really an "ssh" command -- it's a command to the "pash shell" or "ssh payload command" or some such.

I don't have a better wording, but an explanatory comment here might be helpful to folks downstream.
Comment 5 User image Hal Wine [:hwine] (use NI) 2015-10-23 13:51:14 PDT
Comment on attachment 8678307 [details]
MozReview Request: testing: ability to create LDAP accounts without hgAccount object class; r?smacleod

https://reviewboard.mozilla.org/r/23173/#review20649

lgtm - the "issue" is just a comment suggestion, not blocking
Comment 6 User image Hal Wine [:hwine] (use NI) 2015-10-23 13:53:50 PDT
Comment on attachment 8678308 [details]
MozReview Request: hgserver: print helpful message when no HG account is configured (bug 1217964); r?smacleod

https://reviewboard.mozilla.org/r/23175/#review20651

lgtm
Comment 7 User image Hal Wine [:hwine] (use NI) 2015-10-23 13:54:22 PDT
Comment on attachment 8678309 [details]
MozReview Request: hgserver: print more helpful message when no or unknown command is attempted (bug 1217964); r?smacleod

https://reviewboard.mozilla.org/r/23177/#review20653

lgtm
Comment 8 User image Gregory Szorc [:gps] (away until 2017-03-20) 2015-10-23 14:11:58 PDT
https://hg.mozilla.org/hgcustom/version-control-tools/rev/f19958cd8fdc4c036d1e40578d4d847dfa91f8cc
hgserver: print helpful message when no HG account is configured (bug 1217964); r=hwine

https://hg.mozilla.org/hgcustom/version-control-tools/rev/9f4e6a2eafa1a1ea5ddbc3a6bbc99de662b1e31e
hgserver: print better message when no or unknown command is attempted (bug 1217964); r=hwine
Comment 9 User image Gregory Szorc [:gps] (away until 2017-03-20) 2015-10-23 14:13:11 PDT
Deploying now.

Thank you for the quick review. Hopefully fewer people get confused by the state of their accounts now.
Comment 10 User image Gregory Szorc [:gps] (away until 2017-03-20) 2015-11-04 12:32:37 PST
*** Bug 1116796 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.