1217981 - Remove use of for-each from chrome/, config/ and testing/.

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tooru Fujisawa [:arai]]

Need to replace non-standard for-each with one of:
  * for-of
  * for-in
  * array.map/array.filter for array-comprehension
as a part of bug 1083470.

converting rules are following:
  * for-each
    * for each (let x in array) { ... }
      -> for (let x of array) { ... }
    * for each (let x in object) { ... }
      -> for (let key in object) { let x = object[key]; ... }
    * for each (let [key, value] in Iterator(object)) { ... }
      -> for (let key in object) { let value = object[key]; ... }
    * for each (let x in array) { ... }
      where array can be null or undefined
      -> if (array) { for (let x of array) { ... } }

  * legacy array comprehension with for-each
    (newer array comprehension is now also a non-standard feature, I'd like to go with map/filter)
    * [EXPR for each (x in array)]
      -> array.map(x => EXPR)
    * [EXPR for each (x in array) if (COND)]
      -> array.filter(x => COND).map(x => EXPR)
    * [x for each (x in array) if (COND)]
      -> array.filter(x => COND)
    * [EXPR for each ([i, x] in Iterator(array)) if (g(x, i)]
      -> array.filter((x, i) => g(x, i)).map((x => EXPR)
    * [EXPR for each (x in arraylike)]
      -> Array.from(arraylike).map(x => EXPR)
    * [EXPR for each (x in string)]
      -> Array.prototype.slice.call(string).map(x => EXPR)
         // Array.from behaves differently for surrogate-pair

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Part 1: Remove for-each from chrome/.

Almost green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=77c5563839da

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Part 2: Remove for-each from config/.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Part 3: Remove for-each from testing/.

Comment 4

[Benjamin Smedberg]

Comment on attachment 8678316 [details] [diff] [review]
Part 2: Remove for-each from config/.

realistically this code should be removed, but whatever for now

Comment 5

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c64e2afccc7d64f5beef20d8ce21778cc0a015c4
Bug 1217981 - Part 1: Remove for-each from chrome/. r=bsmedberg

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b024fc7d91b6daeb4f44d2189c8787899f97fd9
Bug 1217981 - Part 2: Remove for-each from config/. r=bsmedberg

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1a2ce2eafa9d6a325a384e47fda68e564ff0b00
Bug 1217981 - Part 3: Remove for-each from testing/. r=bsmedberg

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c64e2afccc7d
https://hg.mozilla.org/mozilla-central/rev/8b024fc7d91b
https://hg.mozilla.org/mozilla-central/rev/a1a2ce2eafa9

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/c64e2afccc7d
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8b024fc7d91b
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a1a2ce2eafa9