1218108 - Failure in test_homescreen_launch_app.py in system.wait_for_system_banner_displayed()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

Seeing it here:
http://jenkins1.qa.scl3.mozilla.com/view/Bitbar/job/flame-kk-319.b2g-inbound.tinderbox.ui.functional.smoke.bitbar/3636/HTML_Report/
And locally:


Traceback (most recent call last):
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_client-1.0.0-py2.7.egg/marionette/marionette_test.py", line 277, in run
    self.setUp()
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_launch_app.py", line 37, in setUp
    system.wait_for_system_banner_displayed()
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/apps/system/app.py", line 54, in wait_for_system_banner_displayed
    Wait(self.marionette).until(expected.element_displayed(*self._system_banner_locator))
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_driver-1.0.0-py2.7.egg/marionette_driver/wait.py", line 143, in until
    cause=last_exc)
TEST-INFO took 84658ms

Comment 1

[Martijn Wargers (dead)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/32721

Just add switch_to_frame() to all the methods of the system app, that should prevent these kinds of failures.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8678483 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/32721

Having to repeat switch_to_frame() for every single function of this class is error-prone. I'm fairly sure we can do better (a python class decorator for instance). However, this has never been done in our test suite. The first try will be in bug 1217826.

Hence, I wouldn't block on that. We'll improve this class later.

Comment 3

[No-Jun Park [:njpark]]

Comment on attachment 8678483 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/32721

Actually, this is pretty much what I had to do when dealing with methods that should work under shadow DOM, since I can't make assumptions that it'll be always called within the shadow DOM context.  will look forward for Johan's class decorator implementation.

Comment 5

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/d99c6f1cfc73d3081129f49441770c6a6edfe25e