1218127 - Add tooltips to all @mentions

Status: RESOLVED FIXED

(Chat Core :: Twitter, defect)

Description

[aleth [:aleth]]

Currently @mentions of users who are not participants (i.e. just referenced in a tweet) don't get tooltips. This is inconsistent and feels broken.

Comment 1

[aleth [:aleth]]

Attachment: twitteraddmoretooltips.diff

Comment 2

[aleth [:aleth]]

Attachment: twitteraddmoretooltips.diff v2

Typo fix.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8678599 [details] [diff] [review]
twitteraddmoretooltips.diff v2

Review of attachment 8678599 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/twitter/twitter.js
@@ +308,5 @@
>          entArray = entArray.concat(entities.user_mentions.map(um => ({
>            start: um.indices[0],
>            end: um.indices[1],
>            str: "@" + um.screen_name,
> +          text: '@<span class="ib-person">' + um.screen_name + "</span>",

Can we reuse ib-nick here? If we're adding new ones, they should likely be im, not ib.

Comment 4

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #3)
> > +          text: '@<span class="ib-person">' + um.screen_name + "</span>",
> 
> Can we reuse ib-nick here? If we're adding new ones, they should likely be
> im, not ib.

We can't really reuse ib-nick (added by conversation.xml for participants) as that gets styled with a little bubble and the participant nick colour. I don't think that makes sense here. 

I'm OK with im though.

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8678599 [details] [diff] [review]
twitteraddmoretooltips.diff v2

Seems sane. I'd like Florian to take a quick look.

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/ced21c95ce612c7f093de3418afe2a97a301c8ec
Bug 1218127 - Add tooltips to all twitter @mentions. r=clokep,florian a=aleth chat/ patch on CLOSED TREE

Comment 7

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #4)
> I'm OK with im though.

On second thoughts, I decided to stick with ib for consistency with ib-sender (which already exists and is in use by TB too), as if two of those class names are ib- and one is im- it's just going to be confusing and lead to typos.